refactor(inject): Use new core thread and log modules #295

Open
icex2 wants to merge 12 commits from pr295 into master
icex2 commented 2024-02-23 19:43:02 +03:00 (Migrated from github.com)

refactor(inject): Use new core thread and log modules

Keep this a separate commit because this also removes
inject's own logging engine and replaces it with the
streamlined core API. The core API provides all the
features of inject's own logging engine which also
performed horribly. The entire logging operation
was locked which included expensive operations
that formatted the log messages and required
memory allocations and copying around data.

The core API's implementation at least only
synchronizes the actual IO operations
(though this can be improved further with an
actual async logging sink, TBD)


Stack created with Sapling. Best reviewed with ReviewStack.

refactor(inject): Use new core thread and log modules Keep this a separate commit because this also removes inject's own logging engine and replaces it with the streamlined core API. The core API provides all the features of inject's own logging engine which also performed horribly. The entire logging operation was locked which included expensive operations that formatted the log messages and required memory allocations and copying around data. The core API's implementation at least only synchronizes the actual IO operations (though this can be improved further with an actual async logging sink, TBD) --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/djhackersdev/bemanitools/pull/295). * #298 * #297 * #296 * __->__ #295 * #294 * #293 * #292 * #291 * #290 * #289 * #299 * #288 * #287 * #286 * #285
This pull request has changes conflicting with the target branch.
  • Module.mk
  • src/main/camhook/cam.c
  • src/main/hook/table.c
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin pr295:pr295
git checkout pr295
Sign in to join this conversation.