pr289
master
feat(avs-util): Add helper to translate property errors
Stack created with Sapling. Best reviewed with ReviewStack.
looks good aside from a question about the return value of property_clear_error
@@ -99,0 +103,4 @@
avs_error error;
error = property_get_error(prop);
property_clear_error(prop);
this returns a property* per the earlier stacked commit, is this something we need to be considering?
Nope, I fixed this in https://github.com/djhackersdev/bemanitools/pull/299
No dependencies set.
The note is not visible to the blocked user.
feat(avs-util): Add helper to translate property errors
Stack created with Sapling. Best reviewed with ReviewStack.
looks good aside from a question about the return value of property_clear_error
@@ -99,0 +103,4 @@avs_error error;error = property_get_error(prop);property_clear_error(prop);this returns a property* per the earlier stacked commit, is this something we need to be considering?
@@ -99,0 +103,4 @@avs_error error;error = property_get_error(prop);property_clear_error(prop);Nope, I fixed this in https://github.com/djhackersdev/bemanitools/pull/299