Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

feat(avs): Add property get and clear error functions #288

Merged
icex2 merged 4 commits from pr288 into master 2024-02-25 11:23:02 +03:00
Conversation 3 Commits 4 Files Changed 22
+36 -1
icex2 commented 2024-02-23 19:40:57 +03:00 (Migrated from github.com)
Copy Link
Copy Source

feat(avs): Add property get and clear error functions

Use these to improve error handling by allowing
one to provide additional error information on
property related operations.

Stack created with Sapling. Best reviewed with ReviewStack.

feat(avs): Add property get and clear error functions Use these to improve error handling by allowing one to provide additional error information on property related operations. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/djhackersdev/bemanitools/pull/288). * __->__ #288 * #287 * #286 * #285
willxinc (Migrated from github.com) approved these changes 2024-02-25 01:00:56 +03:00
willxinc (Migrated from github.com) left a comment
Copy Link
Copy Source

pretty self explanatory, looks good to me
why does property_clear_error return a property*, is it just a passthrough?

pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough?
icex2 commented 2024-02-25 11:22:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough?

Don't ask me. =)
The original implementations do that because reasons.

> pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough? Don't ask me. =) The original implementations do that because reasons.
icex2 commented 2024-02-25 11:32:08 +03:00 (Migrated from github.com)
Copy Link
Copy Source

pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough?

Don't ask me. =) The original implementations do that because reasons.

Have to correct my statement, see https://github.com/djhackersdev/bemanitools/pull/299

> > pretty self explanatory, looks good to me why does property_clear_error return a property*, is it just a passthrough? > > Don't ask me. =) The original implementations do that because reasons. Have to correct my statement, see https://github.com/djhackersdev/bemanitools/pull/299
Sign in to join this conversation.
Reviewers
No Reviewers
willxinc
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#288