Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

fix(hook): Add missing hook_table_revert impl #286

Merged
icex2 merged 2 commits from pr286 into master 2024-02-25 11:09:12 +03:00
Conversation 3 Commits 2 Files Changed 2
+82
icex2 commented 2024-02-23 19:40:55 +03:00 (Migrated from github.com)
Copy Link
Copy Source

fix(hook): Add missing hook_table_revert impl

Allow hooks to cleanup when they are shut down.

Stack created with Sapling. Best reviewed with ReviewStack.

fix(hook): Add missing hook_table_revert impl Allow hooks to cleanup when they are shut down. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/djhackersdev/bemanitools/pull/286). * #298 * #297 * #296 * #295 * #294 * #293 * #292 * #291 * #290 * #289 * #288 * #287 * __->__ #286 * #285
willxinc (Migrated from github.com) approved these changes 2024-02-25 00:58:05 +03:00
willxinc (Migrated from github.com) left a comment
Copy Link
Copy Source

Looks good to me, just a question about the failure case, as well as an overall question about when this would be used

Looks good to me, just a question about the failure case, as well as an overall question about when this would be used
src/main/hook/table.c
willxinc (Migrated from github.com) commented 2024-02-25 00:57:44 +03:00
Copy Link
Copy Source

should we log in this case?

should we log in this case?
icex2 (Migrated from github.com) reviewed 2024-02-25 11:00:34 +03:00
src/main/hook/table.c
icex2 (Migrated from github.com) commented 2024-02-25 11:00:34 +03:00
Copy Link
Copy Source

We don't have logging available there. This is the capnhook package. =/

We don't have logging available there. This is the capnhook package. =/
icex2 commented 2024-02-25 11:03:23 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Looks good to me, just a question about the failure case, as well as an overall question about when this would be used

Added reasoning to commit body.

> Looks good to me, just a question about the failure case, as well as an overall question about when this would be used Added reasoning to commit body.
Sign in to join this conversation.
Reviewers
No Reviewers
willxinc
icex2
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#286