Max/zkldi_Tachi
1
0
Fork 0
mirror of https://github.com/zkldi/Tachi.git synced 2026-10-05 21:38:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: convert sdvx lamp properly (booth needs no special handling)

Browse Source
This commit is contained in:
zkldi
2022-12-18 23:01:46 +00:00
parent 78fa39a2fa
commit 7e757448cd
1 changed files with 9 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/lib/score-import/import-types/common/api-cg/sdvx/converter.ts
+9 -27
View File
@@ -42,7 +42,7 @@ export const ConverterAPICGSDVX: ConverterFunction<CGSDVXScore, CGContext> = asy
throw new InternalFailure(`Song-Chart desync with song ID ${chart.songID} (sdvx).`);
}
const lamp = ConvertCGSDVXLamp(version, data.clearType);
const lamp = ConvertCGSDVXLamp(data.clearType);
const { percent, grade } = GenericGetGradeAndPercent("sdvx", data.score, chart);
@@ -114,37 +114,19 @@ function ConvertVersion(ver: number): GPTSupportedVersions["sdvx:Single"] {
* Convert CG's clearType enum into a Tachi lamp. Note that what numbers mean what are
* dependent on what version of the game we're listening for.
*/
function ConvertCGSDVXLamp(
version: GPTSupportedVersions["sdvx:Single"],
clearType: number
): Lamps["sdvx:Single"] {
function ConvertCGSDVXLamp(clearType: number): Lamps["sdvx:Single"] {
switch (clearType) {
case 1:
return "FAILED";
case 2:
return "CLEAR";
case 3:
return "EXCESSIVE CLEAR";
case 4:
return "ULTIMATE CHAIN";
case 5:
return "PERFECT ULTIMATE CHAIN";
}
// this version doesn't have excessive clears, so the ints are off by one.
if (version === "booth") {
switch (clearType) {
case 3:
return "ULTIMATE CHAIN";
case 4:
return "PERFECT ULTIMATE CHAIN";
}
} else {
switch (clearType) {
case 3:
return "EXCESSIVE CLEAR";
case 4:
return "ULTIMATE CHAIN";
case 5:
return "PERFECT ULTIMATE CHAIN";
}
}
throw new InvalidScoreFailure(
`Invalid lamp of ${clearType} for ${version} - Could not convert.`
);
throw new InvalidScoreFailure(`Invalid lamp of ${clearType} - Could not convert.`);
}