Move timeAchieved into the parser context so that it's saved by orphans properly instead of inferred by the converter.

server/src/lib/score-import/import-types/ir/beatoraja/converter.ts

@@ -182,7 +182,7 @@ export const ConverterIRBeatoraja: ConverterFunction<BeatorajaScore, BeatorajaCo
 			inputDevice: data.deviceType,
 			random,
 		},
-		timeAchieved: Date.now(),
+		timeAchieved: context.timeReceived,
 		service: "Beatoraja IR",
 	};
 

server/src/lib/score-import/import-types/ir/beatoraja/parser.ts

@@ -110,12 +110,13 @@ export function ParseBeatorajaSingle(
 		throw new ScoreImportFatalError(400, `Unsupported client ${client}`);
 	}
 
-	// asserted using prudence.
 	return {
 		context: {
 			client: "lr2oraja",
+			// asserted using prudence.
 			chart: body.chart as BeatorajaChart,
 			userID,
+			timeReceived: Date.now(),
 		},
 		game: "bms",
 		iterable: [body.score] as unknown as BeatorajaScore[],

server/src/lib/score-import/import-types/ir/beatoraja/types.ts

@@ -4,6 +4,7 @@ export interface BeatorajaContext {
 	client: "lr2oraja";
 	chart: BeatorajaChart;
 	userID: integer; // unexpectedly necessary for orphan code!
+	timeReceived: number;
 }
 
 export interface BeatorajaChart {

server/src/lib/score-import/import-types/ir/usc/converter.ts

@@ -108,7 +108,7 @@ export const ConverterIRUSC: ConverterFunction<USCClientScore, IRUSCContext> = a
 		comment: null,
 		game: "usc",
 		importType,
-		timeAchieved: Date.now(),
+		timeAchieved: context.timeReceived,
 		service: "USC-IR",
 		scoreData: {
 			grade,

server/src/lib/score-import/import-types/ir/usc/parser.ts

@@ -62,6 +62,7 @@ export function ParseIRUSC(
 		context: {
 			chartHash,
 			playtype,
+			timeReceived: Date.now(),
 		},
 		game: "usc",
 		iterable: [score] as USCClientScore[],

server/src/lib/score-import/import-types/ir/usc/types.ts

@@ -3,4 +3,5 @@ import { Playtypes } from "tachi-common";
 export interface IRUSCContext {
 	chartHash: string;
 	playtype: Playtypes["usc"];
+	timeReceived: number;
 }

server/src/server/router/ir/usc/_playtype/router.ts

@@ -334,9 +334,12 @@ router.post("/scores", RequirePermissions("submit_score"), async (req, res) => {
 				"context.playtype": playtype,
 			});
 
-			await Promise.all(
-				scoresToDeorphan.map((score) => ReprocessOrphan(score, blacklist, logger))
-			);
+			for (const score of scoresToDeorphan) {
+				// Has to be like this to avoid race conditions where two
+				// orphans resolve to the same scoreID and collide in mid-air!
+				// eslint-disable-next-line no-await-in-loop
+				await ReprocessOrphan(score, blacklist, logger);
+			}
 		}
 	}