Max/zkldi_Tachi
1
0
Fork 0
mirror of https://github.com/zkldi/Tachi.git synced 2026-10-10 16:28:17 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove more instances of instanceof

Browse Source 
it's completely broken and no longer honoured. I *still* to this day do
not know why this is a bug on our systems. Maybe I will investigate it
further at some point, but for now, instanceof is banned in the codebase
as it doesn't seem to fucking work.

normally i refrain from swearing in a codebase i know future employers
will check, but this has to be one of *the* most frustrating bugs we've
had in years.
This commit is contained in:
zkldi
2022-09-13 23:28:30 +01:00
parent fab01c3595
commit 0f241e720e
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/lib/score-import/worker/worker.ts
+10 -11
View File
@@ -1,6 +1,5 @@
import ScoreImportQueue from "./queue";
import { GetInputParser } from "../framework/common/get-input-parser";
import ScoreImportFatalError from "../framework/score-importing/score-import-error";
import ScoreImportMain from "../framework/score-importing/score-import-main";
import { Worker } from "bullmq";
import { HandleSIGTERMGracefully } from "lib/handlers/sigterm";
@@ -8,6 +7,7 @@ import CreateLogCtx from "lib/logger/logger";
import { Environment, ServerConfig } from "lib/setup/config";
import { FormatUserDoc, GetUserWithID } from "utils/user";
import { EventEmitter } from "events";
import type ScoreImportFatalError from "../framework/score-importing/score-import-error";
import type { ScoreImportJob, ScoreImportJobData } from "./types";
import type { ImportTypes } from "tachi-common";
@@ -108,8 +108,13 @@ export const worker = new Worker(
logger.debug(`Finished import.`);
return { success: true, importDocument };
} catch (err) {
if (err instanceof ScoreImportFatalError) {
} catch (e) {
const err = e as Error | ScoreImportFatalError;
// originally, we did `err instanceof ScoreImportFatalError`, but something in our toolchain
// has suddenly made all `instanceof` calls faulty. I still - to this day - have absolutely
// no idea why or how this broke, but now `instanceof` is considered a footgun so, great.
if ("statusCode" in err) {
logger.info(
`Job ${job.id} hit ScoreImportFatalError (User Fault) with message: ${err.message}`,
err
@@ -132,14 +137,8 @@ export const worker = new Worker(
const logger = CreateLogCtx("Score Import Worker");
worker.on("failed", (job, err) => {
if (err instanceof ScoreImportFatalError) {
logger.info(
`Job ${job.id} hit ScoreImportFatalError (User Fault) with message: ${err.message}`,
err
);
} else {
logger.error(`Job ${job.id} failed unexpectedly with message: ${err.message}`, err);
}
// any errors that escalate this far are unexpected, as they haven't been caught by previous calls.
logger.error(`Job ${job.id} failed unexpectedly with message: ${err.message}`, err);
});
worker.on("completed", (job, result) => {