Edit #define BOUNCE_LOCK_OUT advice in index.html #86

2022-03-29T00:14:55+03:00

drf5n commented

2022-03-29 00:14:55 +03:00

(Migrated from github.com)

Remove "(or in your code before including "Bounce.h") " per https://github.com/thomasfredericks/Bounce2/issues/85#issuecomment-1081131688 -- it only seems to work if defined in the Bounce2.h file.

Perhaps it is related to https://forum.arduino.cc/t/order-of-include-files/36881/4 and https://arduino.github.io/arduino-cli/dev/sketch-build-process/

I would suppose that the "#define BOUNCE_WITH_PROMPT_DETECTION" would also only work in the .h file.

Remove "(or in your code before including "Bounce.h") " per https://github.com/thomasfredericks/Bounce2/issues/85#issuecomment-1081131688 -- it only seems to work if defined in the Bounce2.h file. Perhaps it is related to https://forum.arduino.cc/t/order-of-include-files/36881/4 and https://arduino.github.io/arduino-cli/dev/sketch-build-process/ I would suppose that the "#define BOUNCE_WITH_PROMPT_DETECTION" would also only work in the .h file.

thomasfredericks commented

2022-03-29 02:56:11 +03:00

(Migrated from github.com)

Yes, it needs to be now defined in the source and not the sketch. The behaviour was changed when bounce was split into a .h and .cpp files. Thank you for submitting the bug.
But the index.html is created by doxygen from the README.md.
I updated the README.md

Yes, it needs to be now defined in the source and not the sketch. The behaviour was changed when bounce was split into a .h and .cpp files. Thank you for submitting the bug. But the index.html is created by doxygen from the README.md. I updated the README.md

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Max/thomasfredericks_Bounce2#86