This version adds the function setInvert (bool invert) with which you can invert the read values. This is practical for pins with INPUT_PULLUP, because you can work with buttons on these pins as well as with pins with INPUT. It is programmed to be backward compatible with older programs. It appears that I changed the whole program because I worked on it offline and then replaced the existing file at GitHub.
This version adds the function setInvert (bool invert) with which you can invert the read values. This is practical for pins with INPUT_PULLUP, because you can work with buttons on these pins as well as with pins with INPUT. It is programmed to be backward compatible with older programs. It appears that I changed the whole program because I worked on it offline and then replaced the existing file at GitHub.
This comment was generated by todo based on a todo comment in 000f1fe060 in #60. cc @NoobTracker.
## Make Bounce2 more abstract. Split it from the hardware layer.
Remove deboucing code from Bounce2 and make a new Debounce class from that code. Bounce2 should extend Debounce.
---
https://github.com/thomasfredericks/Bounce2/blob/000f1fe060e5c18857e476b915e6dae60418854f/src/Bounce2.h#L30-L35
---
###### This comment was generated by [todo](https://todo.jasonet.co) based on a `todo` comment in 000f1fe060e5c18857e476b915e6dae60418854f in #60. cc @NoobTracker.
Thank you for your contribution, but Bounce2 does not encompass the notion of an elevated state akin to on/off, pressed or released in which case the inversion would be relevant. I will not merge but I suggest you extend the Bounce2 class instead to keep your modifications compatible.
Thank you for your contribution, but Bounce2 does not encompass the notion of an elevated state akin to on/off, pressed or released in which case the inversion would be relevant. I will not merge but I suggest you extend the Bounce2 class instead to keep your modifications compatible.
But isn't this lib primarily for debouncing buttons? At least that was why I downloaded it. And that is very useful, because if the program for pulldown resistors is made and you want to use the internal pullup resistors instead, you have to replace every fell with rose, every rose with felland every read with !read.
But isn't this lib primarily for debouncing buttons? At least that was why I downloaded it. And that is very useful, because if the program for pulldown resistors is made and you want to use the internal pullup resistors instead, you have to replace every fell with rose, every rose with felland every read with !read.
It is for any type of contact. Buttons are the primary use. But sometimes you don't push a button, you slide it, etc. I do not want to invert the HIGH or LOW states because that would not match the electrical reality. It is in the todo to make an extended class of Bounce2 specifically for buttons.
It is for any type of contact. Buttons are the primary use. But sometimes you don't push a button, you slide it, etc. I do not want to invert the HIGH or LOW states because that would not match the electrical reality. It is in the todo to make an extended class of Bounce2 specifically for buttons.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
This version adds the function setInvert (bool invert) with which you can invert the read values. This is practical for pins with INPUT_PULLUP, because you can work with buttons on these pins as well as with pins with INPUT. It is programmed to be backward compatible with older programs. It appears that I changed the whole program because I worked on it offline and then replaced the existing file at GitHub.
Make Bounce2 more abstract. Split it from the hardware layer.
Remove deboucing code from Bounce2 and make a new Debounce class from that code. Bounce2 should extend Debounce.
https://github.com/thomasfredericks/Bounce2/blob/000f1fe060e5c18857e476b915e6dae60418854f/src/Bounce2.h#L30-L35
This comment was generated by todo based on a
todocomment in000f1fe060in #60. cc @NoobTracker.Thank you for your contribution, but Bounce2 does not encompass the notion of an elevated state akin to on/off, pressed or released in which case the inversion would be relevant. I will not merge but I suggest you extend the Bounce2 class instead to keep your modifications compatible.
But isn't this lib primarily for debouncing buttons? At least that was why I downloaded it. And that is very useful, because if the program for pulldown resistors is made and you want to use the internal pullup resistors instead, you have to replace every fell with rose, every rose with felland every read with !read.
It is for any type of contact. Buttons are the primary use. But sometimes you don't push a button, you slide it, etc. I do not want to invert the HIGH or LOW states because that would not match the electrical reality. It is in the todo to make an extended class of Bounce2 specifically for buttons.
Okay, you can cross that off the todo list.
Pull request closed