Generic Arduino_STM32 support #58

Merged
fpistm merged 1 commits from patch-1 into master 2020-02-21 02:48:36 +03:00
fpistm commented 2020-02-14 10:06:15 +03:00 (Migrated from github.com)

When BluePill support have been introduced, it was not enough generic
https://github.com/thomasfredericks/Bounce2/pull/35

Board specific definition have been used instead of the generic core one:
ARDUINO_ARCH_STM32F1

See https://www.stm32duino.com/viewtopic.php?f=7&p=1203#p1203

Note:

When BluePill support have been introduced, it was not enough generic https://github.com/thomasfredericks/Bounce2/pull/35 Board specific definition have been used instead of the generic core one: `ARDUINO_ARCH_STM32F1` See https://www.stm32duino.com/viewtopic.php?f=7&p=1203#p1203 Note: * https://github.com/rogerclarkmelbourne/Arduino_STM32 also support STM32F4, so it could be fine to add also: `ARDUINO_ARCH_STM32F4` * For the [STM32 core](https://github.com/stm32duino/Arduino_Core_STM32) no customization needed as it follows Arduino API.
thomasfredericks commented 2020-02-16 16:43:15 +03:00 (Migrated from github.com)

Would it be possible to just know if WiringPinMode is defined?

Would it be possible to just know if WiringPinMode is defined?
fpistm commented 2020-02-16 17:02:03 +03:00 (Migrated from github.com)
Hi @thomasfredericks as it is an enum, I don't think: https://github.com/rogerclarkmelbourne/Arduino_STM32/blob/9d46a1c27d4dc9dd4df06b76a1d81684519d8acc/STM32F1/cores/maple/io.h#L42
thomasfredericks commented 2020-02-16 17:04:15 +03:00 (Migrated from github.com)

But there is #define _WIRISH_IO_H_ and that should be more universal.

But there is `#define _WIRISH_IO_H_` and that should be more universal.
fpistm commented 2020-02-16 17:18:02 +03:00 (Migrated from github.com)

Well this is only the header protection of the file, this is not linked from my point of view.
The patch proposed here use the Arduino core definition linked to that core which is the "official" to identify a core.
The main issue is Roger's core do not follow the standard Arduino API for pinMode anyway it can be easily fixed.

Well this is only the header protection of the file, this is not linked from my point of view. The patch proposed here use the Arduino core definition linked to that core which is the "official" to identify a core. The main issue is Roger's core do not follow the standard Arduino API for pinMode anyway it can be easily fixed.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/thomasfredericks_Bounce2#58