BTstack: remove superfluous call during setup. #2137

Merged
djpearman merged 1 commits from btdev into master 2024-04-30 20:23:36 +03:00
djpearman commented 2024-04-30 13:04:12 +03:00 (Migrated from github.com)

Hi,

The call to le_device_db_init() seems to superfluous as it is called in the subsequent sm_init(). It is not present in BTstack examples I've seen, for example:

https://github.com/bluekitchen/btstack/blob/72ef1732c954d938091467961e41f4aa9b976b34/example/le_streamer_client.c

Removing has no apparent effects (good or bad) in my projects.

Best regards,
djpearman

Hi, The call to `le_device_db_init()` seems to superfluous as it is called in the subsequent `sm_init()`. It is not present in BTstack examples I've seen, for example: https://github.com/bluekitchen/btstack/blob/72ef1732c954d938091467961e41f4aa9b976b34/example/le_streamer_client.c Removing has no apparent effects (good or bad) in my projects. Best regards, djpearman
earlephilhower (Migrated from github.com) approved these changes 2024-04-30 20:23:29 +03:00
earlephilhower (Migrated from github.com) left a comment

Looks good. The BTStackLib is kind of old and not supported by the BTStack guys anymore, so it's not surprising that it's got a little cruft collected in it. :)

Looks good. The BTStackLib is kind of old and not supported by the BTStack guys anymore, so it's not surprising that it's got a little cruft collected in it. :)
Sign in to join this conversation.