Max/earlephilhower_arduino-pico
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases 128 Wiki Activity

Update to Arduino API 1.5.0 #2126

Closed
earlephilhower wants to merge 3 commits from api15 into master
pull from: api15
merge into: :master
Conversation 2 Commits 3 Files Changed 6
+385 -21718
earlephilhower commented 2024-04-26 01:50:38 +03:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
earlephilhower commented 2024-04-26 03:39:47 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Looks like there are examples in the IDE itself with errors with the latest 1.5.0 API. Will sit on this one a bit...

/home/runner/arduino_ide/examples/02.Digital/BlinkWithoutDelay/BlinkWithoutDelay.ino: In function 'void loop()':
/home/runner/arduino_ide/examples/02.Digital/BlinkWithoutDelay/BlinkWithoutDelay.ino:69:26: error: invalid conversion from 'int' to 'PinStatus' [-fpermissive]
   69 |     digitalWrite(ledPin, ledState);
      |                          ^~~~~~~~
      |                          |
      |                          int
Looks like there are examples in the IDE itself with errors with the latest 1.5.0 API. Will sit on this one a bit... ```` /home/runner/arduino_ide/examples/02.Digital/BlinkWithoutDelay/BlinkWithoutDelay.ino: In function 'void loop()': /home/runner/arduino_ide/examples/02.Digital/BlinkWithoutDelay/BlinkWithoutDelay.ino:69:26: error: invalid conversion from 'int' to 'PinStatus' [-fpermissive] 69 | digitalWrite(ledPin, ledState); | ^~~~~~~~ | | | int ````
earlephilhower commented 2024-05-16 02:33:37 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Quick check shows the warning seen here isn't in the 2.2.x IDE, so it's something they've fixed. We do CI w/1.x so therein lies the rub.

Quick check shows the warning seen here isn't in the 2.2.x IDE, so it's something they've fixed. We do CI w/1.x so therein lies the rub.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 debugger
Debugging ssupport
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 freertos
FreeRTOS support
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 platformio
Platform.IO support
 question
Further information is requested
 waiting for feedback
Requires response from original poster
 wontfix
This will not be worked on
No labels wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/earlephilhower_arduino-pico#2126