Fix#4 by sending recent 30 play records in GetUserRecentRatingApi seems to fix this problem.
In GitLab by @NeumPhis on Nov 26, 2019, 06:35
_Merges master -> master_
Fix #4 by sending recent 30 play records in GetUserRecentRatingApi seems to fix this problem.
Minor nitpick but the value of 30 shouldn't be hardcoded in this particular spot, since this is an artifact of the game's scoring rules and not the structure of our database. Please make this a parameter and pass 30 from the call site in getUserRecentRating.ts instead. Might possibly want to rename this method to loadLatest or similar as well although I'll leave that up to your discretion.
Otherwise this PR looks good.
In GitLab by @tau on Nov 27, 2019, 02:19
Commented on [src/chunithm/sql/userPlaylog.ts line 81](https://github.com/djhackersdev/minime/compare/60d2f7cfd3aba0fd49bce38b45f98b3182e56b48..63b43dd13736a3f9b724dfcdcd236e15e626f7c3#diff-7d0d15368db77b42bb8624665087cd57R81)
Minor nitpick but the value of 30 shouldn't be hardcoded in this particular spot, since this is an artifact of the game's scoring rules and not the structure of our database. Please make this a parameter and pass 30 from the call site in `getUserRecentRating.ts` instead. Might possibly want to rename this method to `loadLatest` or similar as well although I'll leave that up to your discretion.
Otherwise this PR looks good.
In GitLab by @NeumPhis on Nov 27, 2019, 02:44
added 1 commit
<ul><li>2884893a - chuni: rename the load latest playlog function name and passing size parameter</li></ul>
[Compare with previous version](/djhackers/minime/merge_requests/2/diffs?diff_id=1086&start_sha=63b43dd13736a3f9b724dfcdcd236e15e626f7c3)
In GitLab by @NeumPhis on Nov 27, 2019, 02:44
Commented on [src/chunithm/sql/userPlaylog.ts line 81](https://github.com/djhackersdev/minime/compare/60d2f7cfd3aba0fd49bce38b45f98b3182e56b48..63b43dd13736a3f9b724dfcdcd236e15e626f7c3#diff-7d0d15368db77b42bb8624665087cd57R81)
changed this line in [version 2 of the diff](/djhackers/minime/merge_requests/2/diffs?diff_id=1086&start_sha=63b43dd13736a3f9b724dfcdcd236e15e626f7c3#438daa718e29edab6cdb90fc443f9d73ce6cd832_81_81)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @NeumPhis on Nov 26, 2019, 06:35
Merges master -> master
Fix #4 by sending recent 30 play records in GetUserRecentRatingApi seems to fix this problem.
In GitLab by @tau on Nov 27, 2019, 02:19
Commented on src/chunithm/sql/userPlaylog.ts line 81
Minor nitpick but the value of 30 shouldn't be hardcoded in this particular spot, since this is an artifact of the game's scoring rules and not the structure of our database. Please make this a parameter and pass 30 from the call site in
getUserRecentRating.tsinstead. Might possibly want to rename this method toloadLatestor similar as well although I'll leave that up to your discretion.Otherwise this PR looks good.
In GitLab by @NeumPhis on Nov 27, 2019, 02:44
added 1 commit
Compare with previous version
In GitLab by @NeumPhis on Nov 27, 2019, 02:44
Commented on src/chunithm/sql/userPlaylog.ts line 81
changed this line in version 2 of the diff
In GitLab by @tau on Nov 27, 2019, 02:49
merged