Update camhook to support new style camera detection #304

Merged
willxinc merged 2 commits from camhook-update into master 2024-05-22 08:29:11 +03:00
willxinc commented 2024-05-21 09:27:34 +03:00 (Migrated from github.com)

This fixes #102 and resolves #90

Tested with a variety of cameras, working:
Logitech C922,
Logitech StreamCam

Not working
Logitech C615

This fixes #102 and resolves #90 Tested with a variety of cameras, working: Logitech C922, Logitech StreamCam Not working Logitech C615
icex2 commented 2024-05-21 12:08:48 +03:00 (Migrated from github.com)

Not working
Logitech C615

Any idea why it is not working? Would be nice if there is a way to test/tell if a cam is compatible.

> Not working > Logitech C615 Any idea why it is not working? Would be nice if there is a way to test/tell if a cam is compatible.
icex2 (Migrated from github.com) reviewed 2024-05-21 12:11:53 +03:00
icex2 (Migrated from github.com) commented 2024-05-21 12:11:52 +03:00

nit: code style camera_data

nit: code style `camera_data`
icex2 (Migrated from github.com) reviewed 2024-05-21 12:13:03 +03:00
icex2 (Migrated from github.com) commented 2024-05-21 12:13:03 +03:00

question: What's old vs. new and why keep the old "thing"?

question: What's old vs. new and why keep the old "thing"?
icex2 (Migrated from github.com) reviewed 2024-05-21 12:14:07 +03:00
@@ -22,6 +22,9 @@ io.tt_multiplier=1.0
# Disables the camera emulation
cam.disable_emu=true
# Camera port layout (0 = LDJ, 1 = CLDJ/TDJ-JA, 2 = TDJ-JB)
icex2 (Migrated from github.com) commented 2024-05-21 12:14:07 +03:00

Can you explain what the port layout implies here regarding which one to chose, e.g. in a home setup? Might be something for the readme.

Can you explain what the port layout implies here regarding which one to chose, e.g. in a home setup? Might be something for the readme.
icex2 (Migrated from github.com) reviewed 2024-05-21 12:18:40 +03:00
icex2 (Migrated from github.com) commented 2024-05-21 12:18:40 +03:00

Still to be done?

Still to be done?
willxinc (Migrated from github.com) reviewed 2024-05-21 12:48:19 +03:00
@@ -22,6 +22,9 @@ io.tt_multiplier=1.0
# Disables the camera emulation
cam.disable_emu=true
# Camera port layout (0 = LDJ, 1 = CLDJ/TDJ-JA, 2 = TDJ-JB)
willxinc (Migrated from github.com) commented 2024-05-21 12:48:18 +03:00

The port layout is used to control which set of ports it pretends the cameras are connected to, will update readme I guess

The port layout is used to control which set of ports it pretends the cameras are connected to, will update readme I guess
willxinc (Migrated from github.com) reviewed 2024-05-21 12:48:20 +03:00
willxinc (Migrated from github.com) commented 2024-05-21 12:48:20 +03:00

it controls the vid/pid used, needs to be kept else old support breaks

it controls the vid/pid used, needs to be kept else old support breaks
willxinc (Migrated from github.com) reviewed 2024-05-21 12:49:20 +03:00
willxinc (Migrated from github.com) commented 2024-05-21 12:49:20 +03:00

ah forgot to remove the comment

ah forgot to remove the comment
willxinc commented 2024-05-21 12:54:26 +03:00 (Migrated from github.com)

Not working
Logitech C615

Any idea why it is not working? Would be nice if there is a way to test/tell if a cam is compatible.

Not easily, I bought one to test, will look into it more in a future fix maybe, I suspect it's due to the supported resolution / features.

> > Not working > > Logitech C615 > > Any idea why it is not working? Would be nice if there is a way to test/tell if a cam is compatible. Not easily, I bought one to test, will look into it more in a future fix maybe, I suspect it's due to the supported resolution / features.
icex2 commented 2024-05-21 18:15:38 +03:00 (Migrated from github.com)

Overall, lgtm already regarding the code itself. A few documentation/information related things that I pointed out can be in a follow-up PR. Feel free to merge this once are done cleaning up.

Overall, lgtm already regarding the code itself. A few documentation/information related things that I pointed out can be in a follow-up PR. Feel free to merge this once are done cleaning up.
lutzchristoph commented 2024-06-09 11:03:49 +03:00 (Migrated from github.com)

Can’t get past the Camera check on sdvx-05.
Used a Sony ZV-E10 as a streaming device, id: “USB\VID_054C&PID_0DE3&MI_00\9&5B8827E&0&0000”
Is it possible to pass this test without a webcam?

Can’t get past the Camera check on sdvx-05. Used a Sony ZV-E10 as a streaming device, id: “USB\VID_054C&PID_0DE3&MI_00\9&5B8827E&0&0000” Is it possible to pass this test without a webcam?
willxinc commented 2024-06-10 01:36:53 +03:00 (Migrated from github.com)

Can’t get past the Camera check on sdvx-05. Used a Sony ZV-E10 as a streaming device, id: “USB\VID_054C&PID_0DE3&MI_00\9&5B8827E&0&0000” Is it possible to pass this test without a webcam?

The changes here are unrelated to SDVX / don't modify the existing camhook behavior, depending on the version it should just skip the camera check. For game-specific support like that I'm not sure this is the best forum for that.

> Can’t get past the Camera check on sdvx-05. Used a Sony ZV-E10 as a streaming device, id: “USB\VID_054C&PID_0DE3&MI_00\9&5B8827E&0&0000” Is it possible to pass this test without a webcam? The changes here are unrelated to SDVX / don't modify the existing camhook behavior, depending on the version it should just skip the camera check. For game-specific support like that I'm not sure this is the best forum for that.
Sign in to join this conversation.