Close: https://github.com/djhackersdev/bemanitools/issues/283
# Test
Launch and connection to the arcana server, playing with a card, NETWORK CHECK
## Windows 11 23H2 (build 22631.3296)
- [x] IIDX9
- [x] IIDX10
- [x] IIDX11
- [x] IIDX12
- [x] IIDX13
- [x] IIDX14
- [ ] IIDX15 (crashed)
- In my environment, it crashes during launch even with the version 5.48.
- From the logs of xrpc and servurl, the changes in this PR seem to be working fine.
- [x] IIDX16
- [x] IIDX17
## Windows 10 1903 (build 18362.356)
The version at the time this comment was committed (Sep 28, 2019): https://github.com/djhackersdev/bemanitools/blob/cbd7720349a51a8a067a939e2f8104f9e2e691bf/src/main/iidxhook-util/eamuse.c#L73-L75
- [x] IIDX9
- [x] IIDX10
- [x] IIDX11
- [x] IIDX12
- [x] IIDX13
Thanks for looking into this as a follow-up to our discussion in the linked issue.
Just skimming this briefly, it seems like this is ready to be reviewed, but your PR title still mentions "WIP". Just want to make sure that you consider your work actually finished before I start review. Please let me know if that's the case.
Thanks for looking into this as a follow-up to our discussion in the linked issue.
Just skimming this briefly, it seems like this is ready to be reviewed, but your PR title still mentions "WIP". Just want to make sure that you consider your work actually finished before I start review. Please let me know if that's the case.
Thanks for looking into this as a follow-up to our discussion in the linked issue.
Just skimming this briefly, it seems like this is ready to be reviewed, but your PR title still mentions "WIP". Just want to make sure that you consider your work actually finished before I start review. Please let me know if that's the case.
The title includes "WIP" because testing is not yet complete, but reviews are welcome.
> Thanks for looking into this as a follow-up to our discussion in the linked issue.
>
> Just skimming this briefly, it seems like this is ready to be reviewed, but your PR title still mentions "WIP". Just want to make sure that you consider your work actually finished before I start review. Please let me know if that's the case.
The title includes "WIP" because testing is not yet complete, but reviews are welcome.
suggestion: Can you adjust the log level to align with what's configured for the hook? That would ensure that the log level can be controlled properly, i.e. to reduce output on normal/production operation.
suggestion: Can you adjust the log level to align with what's configured for the hook? That would ensure that the log level can be controlled properly, i.e. to reduce output on normal/production operation.
It's because it was modeled after the implementation of popnhook.
https://github.com/djhackersdev/bemanitools/blob/master/src/main/popnhook1/avs-boot.c#L72
It's because the implementation of the `ea3_boot` function varies by game version.
https://github.com/gar6a9e/bemanitools/blob/legacy-iidx-network/src/main/iidxhook3/avs-boot.c#L148
What specific steps should be taken?
For example, making it configurable via conf file?
The reason for hardcoding the log level was to follow the existing implementation.
https://github.com/djhackersdev/bemanitools/blob/master/src/main/jbhook1/avs-boot.c#L118
https://github.com/djhackersdev/bemanitools/blob/master/src/main/iidxhook4-cn/avs-boot.c#L81
I see, that's in general an issue that the current setup with logging does not allow for centralized log level management on the older games. I believe this requires more effort to be re-worked properly. Thus, I consider your approach valid and reasonable. Thanks for clarifying.
I see, that's in general an issue that the current setup with logging does not allow for centralized log level management on the older games. I believe this requires more effort to be re-worked properly. Thus, I consider your approach valid and reasonable. Thanks for clarifying.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Close: https://github.com/djhackersdev/bemanitools/issues/283
Test
Launch and connection to the arcana server, playing with a card, NETWORK CHECK
Windows 11 23H2 (build 22631.3296)
Windows 10 1903 (build 18362.356)
The version at the time this comment was committed (Sep 28, 2019): https://github.com/djhackersdev/bemanitools/blob/cbd7720349a51a8a067a939e2f8104f9e2e691bf/src/main/iidxhook-util/eamuse.c#L73-L75
Thanks for looking into this as a follow-up to our discussion in the linked issue.
Just skimming this briefly, it seems like this is ready to be reviewed, but your PR title still mentions "WIP". Just want to make sure that you consider your work actually finished before I start review. Please let me know if that's the case.
The title includes "WIP" because testing is not yet complete, but reviews are welcome.
@@ -0,0 +95,4 @@{log_info("Called my_avs_boot");avs_boot_replace_property_uint32(config, "log/level", 4);suggestion: Can you adjust the log level to align with what's configured for the hook? That would ensure that the log level can be controlled properly, i.e. to reduce output on normal/production operation.
@@ -0,0 +132,4 @@static int my_ea3_boot_avs(struct property_node *config){log_info("Called my_ea3_boot_avs");insert_eamuse_addr(config);question: Why are you inserting the eamuse addr on avs boot? AVS should not have to deal with ea3 related stuff.
@@ -0,0 +48,4 @@{.name = "ea3_boot",.patch = my_ea3_boot,.link = (void **) &real_ea3_boot},};question: Why are there two
ea3_bootfunctions?@@ -0,0 +132,4 @@static int my_ea3_boot_avs(struct property_node *config){log_info("Called my_ea3_boot_avs");insert_eamuse_addr(config);It's because it was modeled after the implementation of popnhook.
https://github.com/djhackersdev/bemanitools/blob/master/src/main/popnhook1/avs-boot.c#L72
@@ -0,0 +48,4 @@{.name = "ea3_boot",.patch = my_ea3_boot,.link = (void **) &real_ea3_boot},};It's because the implementation of the
ea3_bootfunction varies by game version.https://github.com/gar6a9e/bemanitools/blob/legacy-iidx-network/src/main/iidxhook3/avs-boot.c#L148
@@ -0,0 +95,4 @@{log_info("Called my_avs_boot");avs_boot_replace_property_uint32(config, "log/level", 4);What specific steps should be taken?
For example, making it configurable via conf file?
The reason for hardcoding the log level was to follow the existing implementation.
https://github.com/djhackersdev/bemanitools/blob/master/src/main/jbhook1/avs-boot.c#L118
https://github.com/djhackersdev/bemanitools/blob/master/src/main/iidxhook4-cn/avs-boot.c#L81
The testing has been completed.
@@ -0,0 +95,4 @@{log_info("Called my_avs_boot");avs_boot_replace_property_uint32(config, "log/level", 4);I see, that's in general an issue that the current setup with logging does not allow for centralized log level management on the older games. I believe this requires more effort to be re-worked properly. Thus, I consider your approach valid and reasonable. Thanks for clarifying.
Thanks for your efforts and testing your changes across all versions. Changes overall are lgtm and fine to be merged.