Pre-work launcher refactoring #278

Merged
icex2 merged 8 commits from pre-work-launcher-refactoring into master 2024-02-01 00:47:14 +03:00
icex2 commented 2024-01-30 00:03:31 +03:00 (Migrated from github.com)

Extracted from the large changeset that refactors launcher (see https://github.com/djhackersdev/bemanitools/pull/277). See individual commits for details and reasoning.

Extracted from the large changeset that refactors launcher (see https://github.com/djhackersdev/bemanitools/pull/277). See individual commits for details and reasoning.
willxinc (Migrated from github.com) approved these changes 2024-02-01 00:22:48 +03:00
willxinc (Migrated from github.com) left a comment

Looks good to me aside from the formatting issue in Module.mk

The avs import changes could probably be squashed into 1 diff if possible.

Looks good to me aside from the formatting issue in Module.mk The avs import changes could probably be squashed into 1 diff if possible.
willxinc (Migrated from github.com) commented 2024-02-01 00:19:03 +03:00

nit: these should be tabs to match the rest of the file right?

nit: these should be tabs to match the rest of the file right?
willxinc (Migrated from github.com) commented 2024-02-01 00:19:15 +03:00

same nit

same nit
Sign in to join this conversation.