iidxhook: Make settings path in settings hook configurable #235

Merged
icex2 merged 4 commits from iidx-settings-folder-configurable into master 2023-03-19 23:15:29 +03:00
icex2 commented 2023-03-08 19:51:59 +03:00 (Migrated from github.com)

Additional flexibility to cover use-cases like storing this
data on a separate partition which keeps the game data folder
clean and read-only.

Additional flexibility to cover use-cases like storing this data on a separate partition which keeps the game data folder clean and read-only.
willxinc (Migrated from github.com) reviewed 2023-03-11 03:17:13 +03:00
@@ -48,2 +66,3 @@
new_path[1] = '\\';
settings_build_new_path(lpPathName, new_path, sizeof(new_path));
log_misc("(CreateDir) Remapped settings path %s", new_path);
willxinc (Migrated from github.com) commented 2023-03-11 03:17:12 +03:00

Can't you just set the value earlier?

static char settings_path[MAX_PATH] = ".\\";
Can't you just set the value earlier? ``` static char settings_path[MAX_PATH] = ".\\"; ```
willxinc (Migrated from github.com) reviewed 2023-03-11 03:17:15 +03:00
@@ -48,2 +66,3 @@
new_path[1] = '\\';
settings_build_new_path(lpPathName, new_path, sizeof(new_path));
log_misc("(CreateDir) Remapped settings path %s", new_path);
willxinc (Migrated from github.com) commented 2023-03-11 03:17:15 +03:00

nit: this block seems common across hooks, maybe factor it out?

nit: this block seems common across hooks, maybe factor it out?
willxinc (Migrated from github.com) approved these changes 2023-03-11 03:17:32 +03:00
willxinc (Migrated from github.com) left a comment

looks good to me aside from some minor nits

looks good to me aside from some minor nits
Sign in to join this conversation.