zkldi
0e36b17827
This is a long one. So, `instanceof` in Typescript is incredibly flimsy. There's a documented bug with what happens when you extend built-in classes, such as Error or Array. You can read more about it here: https://github.com/Microsoft/TypeScript/wiki/FAQ#why-doesnt-extending-built-ins-like-error-array-and-map-work However, this normally works fine. A previous commit moved some schemas from server/ to common/, our gameSpecific UGPT settings schemas. This caused them to break in an interesting way. For any schema recursive with a depth greater than 1, all errors would be ignored. Why on earth was this happening? Well Prudence passes errors up the stack with a "return Err" -> "if ret instanceof Err: return Err" kind of approach. This normally works fine. The real kicker here is that because server/ and common/ were on 0.9.7 and 0.9.8 respectively, the "Err" instance in question would actually be erased when ran at runtime. The "if ret instance of Err" would fail, because the Err would be from 0.9.7, not 0.9.8. This subtle difference in file results in catastrophic damage. In short. InstanceOf is a footgun. I hate it. Lets never do it again. Thanks.
Tachi Database Seeds
This repository contains some base "seed" files for the Tachi Database.
They are intended to be used with MongoDB, but since these are just a JSON export, you can really do anything you want with them.
Contribution Info
All work should be merged into staging. That branch is synced with the staging deploys of Tachi.
Changes will then be merged and cherry picked into release/v* whenever is best.
What Databases Are Here?
Nothing private, nothing pertaining to an instance of Tachi. These are backbone files, such as songs, charts, and folders.
You can read more about what all these documents mean in common/.
songs-{game}
These contain the song documents for the provided game.
charts-{game}
These contain the chart documents for the provided game.
folders
This contains the set folders for all games.
tables
This contains the set tables for all games.
bms-course-lookup
BMS Dans that should be registered by the IR.
How do I use this?
Depends what you want. If you're familiar with JSON, just take the files and do whatever.
If you want to analyse this data in a more advanced fashion,
install mongodb-tools (You'll want mongoimport in $PATH) from your favourite location.
../_scripts/bootstrap will synchronise these seeds with your local development install on first setup.
You can use server/src/scripts/sync-database to re-synchronise whenever you want.
Contribution
If your change involves inserting or removing records, you must run node scripts/deterministic-collection-sort.js.
This will ensure diffs stay somewhat sane.
I want db dumps for things like scores and users!
Coming soon...