* add inGameID to WACCA charts
* add WACCA import support from MYT
* add client support for api/myt-wacca
* add bot support for api/myt-wacca
* remove artistJP and titleJP from songs-wacca
Turns out these aren't actually in the game data or anything, and we won't be
able to get their values for omni songs or future songs added in plus.
* add some missing omni WACCA songs
* add test
* fix tabs in test.conf.json5
* revamp grpc call handling a bit and add more error handling
* feat: drag the protofiles in rather than alter build
---------
Co-authored-by: zkldi <20380519+zkldi@users.noreply.github.com>
This is a long one.
So, `instanceof` in Typescript is incredibly flimsy. There's a
documented bug with what happens when you extend built-in classes, such
as Error or Array. You can read more about it here: https://github.com/Microsoft/TypeScript/wiki/FAQ#why-doesnt-extending-built-ins-like-error-array-and-map-work
However, this normally works fine. A previous commit moved some schemas
from server/ to common/, our gameSpecific UGPT settings schemas. This
caused them to break in an interesting way. For any schema recursive
with a depth greater than 1, all errors would be ignored. Why on earth
was this happening?
Well Prudence passes errors up the stack with a "return Err" -> "if
ret instanceof Err: return Err" kind of approach. This normally works
fine.
The real kicker here is that because server/ and common/ were on 0.9.7
and 0.9.8 respectively, the "Err" instance in question would actually be
erased when ran at runtime. The "if ret instance of Err" would fail,
because the Err would be from 0.9.7, not 0.9.8. This subtle difference
in file results in catastrophic damage.
In short. InstanceOf is a footgun. I hate it. Lets never do it again.
Thanks.
I'm *pretty* sure it should be inheriting this from the parent tsconfig,
but it doesn't seem like it is. instanceof doesn't work if we're
compiling for ES3, and I think we might be doing that?
