Commit Graph
2464 Commits
Author SHA1 Message Date
zkldi 839fac7bbc refactor!: rename milestones to quests and milestone-sets to questlines 2022-10-18 19:04:29 +01:00
zkldi 910a6756f8 fix: offByOne in initial rival ranking set 2022-10-17 00:21:37 +01:00
zkldi ca4f4be9c0 fix: strict cookie settings also apply to staging
at the moment they were only applied to prod,
which means that browsers wont accept the login cookies

this issue only affects staging
lol
2022-10-16 23:54:19 +01:00
zkldi ffb776e691 feat: recalc rivalRankings when you set new rivals
UNTESTED! lol
2022-10-16 23:47:18 +01:00
zkldi 946752853b fix: override types so AWS passes checks. 2022-10-16 23:05:15 +01:00
zkldi dd5fc52e1e fix: make tests pass 2022-10-16 22:01:14 +01:00
zkldi 0985ca4f8c Merge pull request #715 from TNG-dev/zkldi/rivals 2022-10-16 19:27:00 +01:00
zkldi 1be6acb326 fix: make server tests compile and work 2022-10-16 19:19:58 +01:00
zkldi 3e8dd5a4a6 feat: rivals scorederboard 2022-10-16 18:03:11 +01:00
zkldi 5941902257 feat: set default rival or global rankings 2022-10-16 15:26:00 +01:00
zkldi 0b54d6d862 feat: rival ranking in UI 2022-10-15 02:49:41 +01:00
zkldi 2c3af78b7c feat: rival ranking on server 2022-10-14 23:53:35 +01:00
zkldi d70e30e727 feat: rival chart dropdown
+ more stuff, score graph dropdowns, etc.
2022-10-14 21:21:45 +01:00
zkldi 0e36b17827 fix(critical): Pin prudence to an exact version
This is a long one.

So, `instanceof` in Typescript is incredibly flimsy. There's a
documented bug with what happens when you extend built-in classes, such
as Error or Array. You can read more about it here: https://github.com/Microsoft/TypeScript/wiki/FAQ#why-doesnt-extending-built-ins-like-error-array-and-map-work

However, this normally works fine. A previous commit moved some schemas
from server/ to common/, our gameSpecific UGPT settings schemas. This
caused them to break in an interesting way. For any schema recursive
with a depth greater than 1, all errors would be ignored. Why on earth
was this happening?

Well Prudence passes errors up the stack with a "return Err" -> "if
ret instanceof Err: return Err" kind of approach. This normally works
fine.

The real kicker here is that because server/ and common/ were on 0.9.7
and 0.9.8 respectively, the "Err" instance in question would actually be
erased when ran at runtime. The "if ret instance of Err" would fail,
because the Err would be from 0.9.7, not 0.9.8. This subtle difference
in file results in catastrophic damage.

In short. InstanceOf is a footgun. I hate it. Lets never do it again.
Thanks.
2022-10-14 01:09:31 +01:00
zkldi c6c716c0f7 feat: control what bms tables appear visually 2022-10-14 00:04:34 +01:00
zkldi 09becfcc3a feat: add bms displayTables to gameSpecific settings, refactor duplicate implementation out 2022-10-14 00:04:34 +01:00
zkldi 8db22b7ff4 fix: make sure git configuration occurs in a git repo
otherwise it will fail. very crazy stuff going on today huh.
2022-10-14 00:04:34 +01:00
zkldi de3cc0fd11 feat: revert integration endpoint 2022-10-14 00:04:34 +01:00
zkldi 28116909a1 feat: support sdvxInGameID as a matchType
this allows ANY_INF to be passed as a difficulty, which is convenient
for scripts that import from services that consider all of INF/GRV/HVN...
to be equivalent
2022-10-14 00:04:34 +01:00
zkldi 7591ad69b2 fix: account for context.version in inGameID batch-manual importing 2022-10-14 00:04:34 +01:00
zkldi 20ff2b0212 fix: arc no longer crashes due to _id clobbering 2022-10-14 00:04:34 +01:00
zkldi b4778040ff fix: separate some migrations to boku/kamai specific
since some migrations are boku/kamai specific, them
running on the wrong thing causes unecessary stress
and gray hairs
for me
2022-10-11 19:23:48 +01:00
zkldi 695fa98fec feat: mount migration
confirmed to work on local hardware, should be good.
2022-10-07 01:48:21 +01:00
zkldi ac0debe2e9 feat: add migration script for iidx notecounts 2022-10-07 01:09:12 +01:00
zkldi 18b0eac821 fix: make sync-database-local work
also, use sync-database-local instead of sync-database when running
bootstrap.sh
2022-10-07 01:09:12 +01:00
zkldi 0a189a9eb6 Merge pull request #703 from TNG-dev/zkldi/new-tables 2022-10-03 21:22:02 +01:00
zkldi c6dfae2cf2 feat: update how bms-table-sync works 2022-10-03 20:39:03 +01:00
zkldi 842c0b2e66 Merge pull request #702 from Bottersnike/fix/samesite-none-in-dev 2022-10-03 11:53:31 +01:00
Bottersnike dc231f43f0 Drunk test name 2022-10-03 00:06:25 +01:00
Bottersnike fef6ed4688 Fix auth cookies on newer chromium builds 2022-10-03 00:02:52 +01:00
Bottersnike 7e8315e7a6 Permit zero-length strings for about me 2022-10-02 23:51:25 +01:00
zkldi 131e0f2dc9 fix: use proper paths to deterministic coll sort 2022-09-30 13:26:54 +01:00
zkldi ccb6ec74a5 fix: remove useless test 2022-09-30 12:30:54 +01:00
zkldi 3dd7737096 fix(test): add regression tests for invites 2022-09-30 11:21:25 +01:00
zkldi df1082909f style(server): fix imports 2022-09-29 19:26:42 +01:00
zkldi ab9955c0e1 fix(server): make /invites routes check if invites are enabled
instead of checking if it's kamaitachi, since that's
less reliable (staging.bokutachi has invites)
2022-09-29 19:24:03 +01:00
zkldi 2c8ae63171 fix(test): fix test regression with new pb handling 2022-09-29 15:25:25 +01:00
zkldi 87eb00adef fix: inherit combobreak from lampPB instead of scorePB 2022-09-29 11:29:14 +01:00
zkldi 6ab9ba7e33 fix: always apply lampPB merging
THIS WAS BROKEN!!! if a BP PB (lol) did not exist
then no lamp merging would happen.

whoops.
2022-09-29 11:29:14 +01:00
zkldi 0385cb65f9 Merge branch 'staging' into zkldi/seeds-ui 2022-09-28 22:34:22 +01:00
zkldi ece7584d7e feat: add get-single-commit endpoint 2022-09-24 11:02:32 +01:00
zkldi f8229e3e8a feat: add fetching single commit 2022-09-24 11:02:25 +01:00
zkldi d80f7c4f47 feat: folders, songs 2022-09-22 23:31:47 +01:00
zkldi 947abe5867 feat: able to load seeds from remote and local
this isn't very performant. maybe we can look into ways
of improving this down the road.
2022-09-22 00:15:40 +01:00
zkldi 29833548fd fix: allow maxBuffer to be 1G from shell exec
Honestly, not sure why this exists and why the cap
is so low. Maybe some node guy can explain this to me.

Ah well. We don't execute anything that should DOS us
and we certainly don't let user input hit this function
so, we should be good.
2022-09-21 22:19:11 +01:00
zkldi c5c107a0b2 feat: uncommitted changes UI 2022-09-21 21:33:38 +01:00
zkldi 76b59bf44d feat: uncommitted changes detection 2022-09-20 23:49:21 +01:00
zkldi 5e9bc26663 feat: use separate path for testing /seeds routes 2022-09-20 22:30:20 +01:00
zkldi 3a9d982815 refactor: use collections as the base for dbseedsrepo
also, change `dontDestroy` to the far more intuitive `shouldDestroy`.
2022-09-20 22:29:17 +01:00
zkldi 55271117a2 feat: local-seeds draft + commit searcher 2022-09-20 01:02:55 +01:00