diff --git a/server/package.json b/server/package.json index 90b53e30e..a1ff145c8 100644 --- a/server/package.json +++ b/server/package.json @@ -1,6 +1,6 @@ { "name": "tachi-server", - "version": "2.0.20", + "version": "2.0.22", "description": "A score tracking server.", "main": "js/index.js", "private": true, diff --git a/server/src/lib/constants/version.ts b/server/src/lib/constants/version.ts index 068113853..969b239b1 100644 --- a/server/src/lib/constants/version.ts +++ b/server/src/lib/constants/version.ts @@ -4,7 +4,7 @@ const MAJOR = 2; const MINOR = 0; -const PATCH = 20; +const PATCH = 22; // As is with all front-facing zkldi projects, the version names for tachi-server // are from an album I like. In this case, the album is Portishead - Dummy. diff --git a/server/src/server/router/ir/beatoraja/charts/convert-scores.ts b/server/src/server/router/ir/beatoraja/charts/convert-scores.ts index 7bd31380b..90bc1a5d6 100644 --- a/server/src/server/router/ir/beatoraja/charts/convert-scores.ts +++ b/server/src/server/router/ir/beatoraja/charts/convert-scores.ts @@ -70,8 +70,8 @@ export function TachiScoreDataToBeatorajaFormat( const judgements: Partial = {}; - // Not everything exports these properties. If they're not there, they should default to 0. - // For cases like LR2/manual - this will just result in a set of 0s. + // // Not everything exports these properties. If they're not there, they should default to 0. + // // For cases like LR2/manual - this will just result in a set of 0s. for (const key of [ "epg", "lpg", @@ -89,12 +89,17 @@ export function TachiScoreDataToBeatorajaFormat( judgements[key] = scoreData.hitMeta[key] ?? 0; } - // If we have no epg/egr data, we can't calculate EX score on the beatoraja client. - // We have to fake some data for LR2 scores/other scores. - if (!judgements.epg && !judgements.lpg && !judgements.egr && !judgements.lgr) { - judgements.epg = Math.floor(pbScore.scoreData.score / 2); - judgements.egr = pbScore.scoreData.score % 2; - } + // // If we have no epg/egr data, we can't calculate EX score on the beatoraja client. + // // We have to fake some data for LR2 scores/other scores. + // if (!judgements.epg && !judgements.lpg && !judgements.egr && !judgements.lgr) { + + // As a temporary measure, we are going to always enable this hack. + // It seems like there are a lot of old CN scores that have completely + // invalid values for these judgement fields. + // truly fun. + judgements.epg = Math.floor(pbScore.scoreData.score / 2); + judgements.egr = pbScore.scoreData.score % 2; + // } return { ...beatorajaScore, ...judgements }; }