Max/zkldi_Tachi
1
0
Fork 0
mirror of https://github.com/zkldi/Tachi.git synced 2026-10-11 16:58:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add warning for why we don't log errors

Browse Source
This commit is contained in:
zkldi
2022-03-03 03:43:20 +00:00
parent 147f78171a
commit f9c162fc11
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/lib/database-seeds/repo.ts
+14
View File
@@ -106,6 +106,20 @@ export class DatabaseSeedsRepo {
return false;
}
// Ok, Testing this is actually a bad idea. Hear me out.
// It's exceptionally difficult to actually store and look at the test output. (potentially huge)
// especially when filesystem size is our biggest constraint at the moment.
//
// It's better for us to commit straight away, and have the tests on our github CI fail
// (and subsequently yell at us.)
//
// try {
// await asyncExec(`cd "${this.baseDir}/scripts" || exit 2; pnpm install; pnpm test`);
// } catch ({ err, stdout, stderr }) {
// logger.error(`Testing the changes failed. ${err}. Not committing back!`, { err });
// throw err;
// }
this.logger.info(`Changes. Committing changes back.`);
const { stdout: commitOut } = await asyncExec(