From e6d369733f79782491e143c8fc618af780fda445 Mon Sep 17 00:00:00 2001 From: zkldi <20380519+zkldi@users.noreply.github.com> Date: Thu, 2 Dec 2021 10:30:08 +0000 Subject: [PATCH] Fix KAI returns -1 for No dan #488 --- .../import-types/common/api-kai/sdvx/class-handler.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/server/src/lib/score-import/import-types/common/api-kai/sdvx/class-handler.ts b/server/src/lib/score-import/import-types/common/api-kai/sdvx/class-handler.ts index 7e3f01b7d..a637de914 100644 --- a/server/src/lib/score-import/import-types/common/api-kai/sdvx/class-handler.ts +++ b/server/src/lib/score-import/import-types/common/api-kai/sdvx/class-handler.ts @@ -36,7 +36,7 @@ export async function CreateKaiSDVXClassHandler( const sdvxDan: number | null = json.skill_level - 1; - if (sdvxDan === null) { + if (sdvxDan === null || sdvxDan === undefined) { return {}; } @@ -52,6 +52,12 @@ export async function CreateKaiSDVXClassHandler( return {}; } + // Kai APIs return -1 to indicate no dan. They also sometimes return undefined. + // I'm not too sure why. + if (sdvxDan === -1) { + return {}; + } + if (sdvxDan < SDVXDans.DAN_1) { logger.warn( `${baseUrl} returned a dan of ${sdvxDan}, which was less than DAN_1 (${SDVXDans.DAN_1}.)`