From 06654e2e4c88fdafe79bc8238346901ab78ec546 Mon Sep 17 00:00:00 2001 From: zkldi <20380519+zkldi@users.noreply.github.com> Date: Thu, 9 Dec 2021 01:40:01 +0000 Subject: [PATCH 1/2] Make critical optimisation to update-score.ts --- server/src/lib/score-mutation/update-score.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/server/src/lib/score-mutation/update-score.ts b/server/src/lib/score-mutation/update-score.ts index e1aa8f9e4..0e9b27458 100644 --- a/server/src/lib/score-mutation/update-score.ts +++ b/server/src/lib/score-mutation/update-score.ts @@ -2,6 +2,7 @@ import db from "external/mongo/db"; import { KtLogger, rootLogger } from "lib/logger/logger"; import { CreateCalculatedData } from "lib/score-import/framework/calculated-data/calculated-data"; +import { UpdateChartRanking } from "lib/score-import/framework/pb/create-pb-doc"; import { CreateScoreID } from "lib/score-import/framework/score-importing/score-id"; import { ScoreDocument } from "tachi-common"; import { UpdateAllPBs } from "utils/calculations/recalc-scores"; @@ -123,13 +124,16 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco // We run updateAllPbs on just the modified chart -- the reason // for this is to update ranking info incase that might fall out of // sync as a result. - await UpdateAllPBs(undefined, { + await UpdateAllPBs([userID], { chartID: newScore.chartID, }); - await UpdateAllPBs(undefined, { + await UpdateAllPBs([userID], { chartID: oldScore.chartID, }); + await UpdateChartRanking(newScore.chartID); + await UpdateChartRanking(oldScore.chartID); + const imports = await db.imports.find({ scoreIDs: oldScoreID, }); From 1306eab2729c1e58e082063d895129c0fdb000b3 Mon Sep 17 00:00:00 2001 From: zkldi <20380519+zkldi@users.noreply.github.com> Date: Thu, 9 Dec 2021 01:41:57 +0000 Subject: [PATCH 2/2] downgrade log level to reduce spam# Please enter the commit message for your changes. Lines starting --- server/src/lib/score-mutation/update-score.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/src/lib/score-mutation/update-score.ts b/server/src/lib/score-mutation/update-score.ts index 0e9b27458..3f23762e8 100644 --- a/server/src/lib/score-mutation/update-score.ts +++ b/server/src/lib/score-mutation/update-score.ts @@ -57,7 +57,7 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco context: ["Update Score", oldScore.scoreID, newScore.scoreID, FormatUserDoc(user)], }) as KtLogger; - logger.info("Received Update Score request."); + logger.verbose("Received Update Score request."); newScore.calculatedData = await CreateCalculatedData( newScore, @@ -83,7 +83,7 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco "scoreInfo.scoreID": oldScoreID, }); - logger.info(`Updating ${sessions.length} sessions.`); + logger.verbose(`Updating ${sessions.length} sessions.`); // For every session that interacts with this score ID (there should only ever be one) for (const session of sessions) { @@ -118,7 +118,7 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco ); } - logger.info(`Updating PBs.`); + logger.verbose(`Updating PBs.`); // Update the PBs to reference properly. // We run updateAllPbs on just the modified chart -- the reason @@ -138,7 +138,7 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco scoreIDs: oldScoreID, }); - logger.info(`Updating ${imports.length} imports.`); + logger.verbose(`Updating ${imports.length} imports.`); for (const importDoc of imports) { await db.imports.update( @@ -153,5 +153,5 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco ); } - logger.info(`Done updating score.`); + logger.verbose(`Done updating score.`); }