From d705aa94ccca3199178172bf8d0971016f278d67 Mon Sep 17 00:00:00 2001 From: zkldi <20380519+zkldi@users.noreply.github.com> Date: Fri, 1 Apr 2022 19:05:39 +0100 Subject: [PATCH] User's own scores are returned in a way which doesn't let beatoraja interpret them correctly Fixes #677 --- .../server/router/ir/beatoraja/charts/_chartSHA256/router.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/src/server/router/ir/beatoraja/charts/_chartSHA256/router.ts b/server/src/server/router/ir/beatoraja/charts/_chartSHA256/router.ts index 391138cf5..1e5088801 100644 --- a/server/src/server/router/ir/beatoraja/charts/_chartSHA256/router.ts +++ b/server/src/server/router/ir/beatoraja/charts/_chartSHA256/router.ts @@ -1,6 +1,6 @@ import { RequestHandler, Router } from "express"; import db from "external/mongo/db"; -import { SYMBOL_TachiData } from "lib/constants/tachi"; +import { SYMBOL_TachiAPIAuth, SYMBOL_TachiData } from "lib/constants/tachi"; import { ChartDocument, PBScoreDocument } from "tachi-common"; import { AssignToReqTachiData } from "utils/req-tachi-data"; import { TachiScoreDataToBeatorajaFormat } from "./convert-scores"; @@ -43,6 +43,7 @@ router.use(GetChartDocument); */ router.get("/scores", async (req, res) => { const chart = req[SYMBOL_TachiData]!.beatorajaChartDoc!; + const requestingUserID = req[SYMBOL_TachiAPIAuth].userID; const scores = (await db["personal-bests"].find({ chartID: chart.chartID, @@ -72,7 +73,7 @@ router.get("/scores", async (req, res) => { TachiScoreDataToBeatorajaFormat( score, chart.data.hashSHA256, - userMap.get(score.userID).username, + score.userID === requestingUserID ? "" : userMap.get(score.userID).username, chart.data.notecount, 0 // Playcount is always 0 at the moment due to performance concerns. )