From b6188deb64233f9b053d11486d4ef083c0ee5366 Mon Sep 17 00:00:00 2001
From: zkldi <notzkldi@zkldi.com>
Date: Wed, 9 Jun 2021 14:19:55 +0100
Subject: [PATCH] Resolves #138

---
 .../score-import/import-types/ir/beatoraja/converter.ts   | 8 +++++++-
 .../server/router/ir/beatoraja/charts/convert-scores.ts   | 3 ++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/server/src/lib/score-import/import-types/ir/beatoraja/converter.ts b/server/src/lib/score-import/import-types/ir/beatoraja/converter.ts
index 8c0780da2..d7a68076a 100644
--- a/server/src/lib/score-import/import-types/ir/beatoraja/converter.ts
+++ b/server/src/lib/score-import/import-types/ir/beatoraja/converter.ts
@@ -104,6 +104,12 @@ export const ConverterIRBeatoraja: ConverterFunction<BeatorajaScore, BeatorajaCo
         };
     }
 
+    let random = null;
+
+    if (chart.playtype === "7K") {
+        random = RANDOM_LOOKUP[data.option];
+    }
+
     const lamp = LAMP_LOOKUP[data.clear];
 
     const dryScore: DryScore<"bms:7K" | "bms:14K"> = {
@@ -121,7 +127,7 @@ export const ConverterIRBeatoraja: ConverterFunction<BeatorajaScore, BeatorajaCo
         scoreMeta: {
             client: context.client,
             inputDevice: data.deviceType,
-            random: RANDOM_LOOKUP[data.option] ?? null,
+            random,
         },
         timeAchieved: Date.now(),
         service: "Beatoraja IR",
diff --git a/server/src/server/router/ir/beatoraja/charts/convert-scores.ts b/server/src/server/router/ir/beatoraja/charts/convert-scores.ts
index e7c2ba642..6e4105857 100644
--- a/server/src/server/router/ir/beatoraja/charts/convert-scores.ts
+++ b/server/src/server/router/ir/beatoraja/charts/convert-scores.ts
@@ -102,7 +102,8 @@ function TachiScoreDataToBeatorajaFormat(
 
     let rajaRandom = 0 as const;
 
-    // @todo #138 Investigate how beatoraja handles DP randoms - for now, we just skip them.
+    // Beatoraja does not support DP randoms - it only stores them in replay files,
+    // and only sends the left hand random here.
     if (pbScore.playtype === "7K") {
         if (random) {
             // @ts-expect-error Invalid indexing because playtype removes the random tuple.