From a64a4c16b4798448ef803c9fc998655b02bc209b Mon Sep 17 00:00:00 2001
From: zkldi <20380519+zkldi@users.noreply.github.com>
Date: Sat, 11 Jun 2022 17:29:31 +0100
Subject: [PATCH] test: add tests for new global search functionality

---
 .../router/api/v1/search/router.test.ts       | 49 ++++++++++++++++++-
 .../src/server/router/api/v1/search/router.ts |  6 ++-
 2 files changed, 51 insertions(+), 4 deletions(-)

diff --git a/server/src/server/router/api/v1/search/router.test.ts b/server/src/server/router/api/v1/search/router.test.ts
index 86cd5965b..deb2591b9 100644
--- a/server/src/server/router/api/v1/search/router.test.ts
+++ b/server/src/server/router/api/v1/search/router.test.ts
@@ -1,8 +1,10 @@
+import db from "external/mongo/db";
 import t from "tap";
+import { mkFakeGameSettings, mkFakeUser } from "test-utils/misc";
 import mockApi from "test-utils/mock-api";
 import ResetDBState from "test-utils/resets";
 import { LoadTachiIIDXData } from "test-utils/test-data";
-import type { SongDocument } from "tachi-common";
+import type { ChartDocument, SongDocument } from "tachi-common";
 
 t.test("GET /api/v1/search", (t) => {
 	t.beforeEach(ResetDBState);
@@ -14,6 +16,26 @@ t.test("GET /api/v1/search", (t) => {
 		t.equal(res.body.body.users.length, 1);
 
 		t.equal(res.body.body.users[0].username, "test_zkldi");
+		t.equal(res.body.body.users[0].__isRival, false);
+
+		t.end();
+	});
+
+	t.test("Should highlight users as rivals if they're rivals of the requester", async (t) => {
+		await db.users.insert(
+			mkFakeUser(2, { username: "scoobydoo", usernameLowercase: "scoobydoo" })
+		);
+
+		await db["game-settings"].remove({});
+		await db["game-settings"].insert(mkFakeGameSettings(1, "iidx", "SP", { rivals: [] }));
+
+		const res = await mockApi
+			.get("/api/v1/search?search=scoobydoo")
+			.set("Authorization", "Bearer fake_api_token");
+
+		t.equal(res.body.body.users.length, 1);
+
+		t.equal(res.body.body.users[0].__isRival, true);
 
 		t.end();
 	});
@@ -21,7 +43,6 @@ t.test("GET /api/v1/search", (t) => {
 	t.test("Should search songs.", async (t) => {
 		const res = await mockApi.get("/api/v1/search?search=AA");
 
-		t.equal(res.body.body.songs.length, 2);
 		t.strictSame(
 			res.body.body.songs.map((e: SongDocument) => e.title),
 			["AA", "AA -rebuild-"]
@@ -30,6 +51,30 @@ t.test("GET /api/v1/search", (t) => {
 		t.end();
 	});
 
+	t.test("Should search charts.", async (t) => {
+		const res = await mockApi.get("/api/v1/search?search=AA");
+
+		t.strictSame(
+			res.body.body.charts.map((e: ChartDocument) => e.chartID),
+			[
+				"f50fada294fd94afb48215c172bafcd686abf80d",
+				"dc63134bd7da647e67e6074f37179da30739ef62",
+				"0f059e53963850860c98298b9b9c25e07c3a35df",
+				"0e1fbd5bfe34351cb8c4869eddebc34241ec4546",
+				"c873be77d89ae1bc3c1bac75ddf9b2de5a3fe6af",
+				"95bd4cfdc20bf8a510abe7fa07fe6bb7393e95ab",
+				"45c4c6c8fc966c1456206f713110b463f9bedde2",
+				"15c2dc36d57a469ce6e0655ef968528149f08854",
+				"557a1536509108ab9a0e146110a3227fc0c5b0aa",
+				"294f86a9f4dc7116d82f3d495c5aae59f093030a",
+				"fb057b61b91df7fb01027182d3be01aadebcec94",
+				"29b8fb636805f70b8918ff4654838b474619154f",
+			]
+		);
+
+		t.end();
+	});
+
 	t.test("Should reject requests without a query.", async (t) => {
 		const res = await mockApi.get("/api/v1/search");
 
diff --git a/server/src/server/router/api/v1/search/router.ts b/server/src/server/router/api/v1/search/router.ts
index e8bf87e43..d142ed389 100644
--- a/server/src/server/router/api/v1/search/router.ts
+++ b/server/src/server/router/api/v1/search/router.ts
@@ -58,8 +58,10 @@ router.get("/", async (req, res) => {
 		SearchFolders(req.query.search, filter),
 	]);
 
-	const songs = songChartData.map((e) => e.songs.map((song) => ({ game: e.game, ...song })));
-	const charts = songChartData.map((e) => e.charts.map((chart) => ({ game: e.game, ...chart })));
+	const songs = songChartData.flatMap((e) => e.songs.map((song) => ({ game: e.game, ...song })));
+	const charts = songChartData.flatMap((e) =>
+		e.charts.map((chart) => ({ game: e.game, ...chart }))
+	);
 
 	// @ts-expect-error Handled below -- the field is added by the below for loop.
 	const usersWithRivalTag: Array<PublicUserDocument & { __isRival: boolean }> = users;