From a364f23cd348bfc8ab665e87ee6388b352c46a90 Mon Sep 17 00:00:00 2001
From: zkldi <20380519+zkldi@users.noreply.github.com>
Date: Thu, 9 Dec 2021 13:13:02 +0000
Subject: [PATCH] Make sure update-score removes a score if all references to
 it are popped

---
 server/src/lib/score-mutation/update-score.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/server/src/lib/score-mutation/update-score.ts b/server/src/lib/score-mutation/update-score.ts
index 3f23762e8..f2f0f4f0c 100644
--- a/server/src/lib/score-mutation/update-score.ts
+++ b/server/src/lib/score-mutation/update-score.ts
@@ -75,8 +75,11 @@ export default async function UpdateScore(oldScore: ScoreDocument, newScore: Sco
 		);
 	} catch (err) {
 		logger.warn(
-			`Score ID ${newScoreID} already existed -- this update caused a collision. Updating old references anyway.`
+			`Score ID ${newScoreID} already existed -- this update caused a collision. Removing old score and updating old references anyway.`
 		);
+		await db.scores.remove({
+			scoreID: oldScoreID,
+		});
 	}
 
 	const sessions = await db.sessions.find({