From 9a2eae3f7ea0f1465bc90dc5e947c5fa4bccc17b Mon Sep 17 00:00:00 2001 From: zkldi <20380519+zkldi@users.noreply.github.com> Date: Sun, 18 Dec 2022 23:52:14 +0000 Subject: [PATCH] fix: timezone issues --- .../import-types/common/api-cg/museca/converter.test.ts | 6 +++++- .../import-types/common/api-cg/popn/converter.test.ts | 6 +++++- .../import-types/common/api-cg/sdvx/converter.test.ts | 6 +++++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/server/src/lib/score-import/import-types/common/api-cg/museca/converter.test.ts b/server/src/lib/score-import/import-types/common/api-cg/museca/converter.test.ts index 0f97941d8..529fed82f 100644 --- a/server/src/lib/score-import/import-types/common/api-cg/museca/converter.test.ts +++ b/server/src/lib/score-import/import-types/common/api-cg/museca/converter.test.ts @@ -1,5 +1,6 @@ import { ConverterAPICGMuseca } from "./converter"; import CreateLogCtx from "lib/logger/logger"; +import { ParseDateFromString } from "lib/score-import/framework/common/score-utils"; import t from "tap"; import { dmf } from "test-utils/misc"; import type { CGContext, CGMusecaScore } from "../types"; @@ -31,7 +32,10 @@ function mkOutput(modifant: any = {}): DryScore<"museca:Single"> { comment: null, game: "museca", importType: "api/cg-dev-museca", - timeAchieved: 1559805262000, + + // we handle it like this because -- with no timezone info + // this will fail in CI; it has a different timezone there! + timeAchieved: ParseDateFromString("2019-06-06 08:14:22"), service: "CG Dev", scoreData: { grade: "優", diff --git a/server/src/lib/score-import/import-types/common/api-cg/popn/converter.test.ts b/server/src/lib/score-import/import-types/common/api-cg/popn/converter.test.ts index e57c54f0a..735adf42d 100644 --- a/server/src/lib/score-import/import-types/common/api-cg/popn/converter.test.ts +++ b/server/src/lib/score-import/import-types/common/api-cg/popn/converter.test.ts @@ -1,5 +1,6 @@ import { ConverterAPICGPopn } from "./converter"; import CreateLogCtx from "lib/logger/logger"; +import { ParseDateFromString } from "lib/score-import/framework/common/score-utils"; import t from "tap"; import { dmf } from "test-utils/misc"; import type { CGContext, CGPopnScore } from "../types"; @@ -30,7 +31,10 @@ function mkOutput(modifant: any = {}): DryScore<"popn:9B"> { comment: null, game: "popn", importType: "api/cg-dev-popn", - timeAchieved: 1559805262000, + + // we handle it like this because -- with no timezone info + // this will fail in CI; it has a different timezone there! + timeAchieved: ParseDateFromString("2019-06-06 08:14:22"), service: "CG Dev", scoreData: { grade: "A", diff --git a/server/src/lib/score-import/import-types/common/api-cg/sdvx/converter.test.ts b/server/src/lib/score-import/import-types/common/api-cg/sdvx/converter.test.ts index e7b2cc3a1..4dd91eb48 100644 --- a/server/src/lib/score-import/import-types/common/api-cg/sdvx/converter.test.ts +++ b/server/src/lib/score-import/import-types/common/api-cg/sdvx/converter.test.ts @@ -1,5 +1,6 @@ import { ConverterAPICGSDVX } from "./converter"; import CreateLogCtx from "lib/logger/logger"; +import { ParseDateFromString } from "lib/score-import/framework/common/score-utils"; import t from "tap"; import { dmf } from "test-utils/misc"; import type { CGContext, CGSDVXScore } from "../types"; @@ -32,7 +33,10 @@ function mkOutput(modifant: any = {}): DryScore<"sdvx:Single"> { comment: null, game: "sdvx", importType: "api/cg-dev-sdvx", - timeAchieved: 1559805262000, + + // we handle it like this because -- with no timezone info + // this will fail in CI; it has a different timezone there! + timeAchieved: ParseDateFromString("2019-06-06 08:14:22"), service: "CG Dev", scoreData: { grade: "A+",