From 515db2e96ee4e92e10ccfeca5c480aee415bd909 Mon Sep 17 00:00:00 2001
From: zkldi <20380519+zkldi@users.noreply.github.com>
Date: Fri, 8 Apr 2022 18:32:12 +0100
Subject: [PATCH] Allow instantly-achieving milestones on subscription time.

---
 .../_playtype/targets/milestones/router.ts      | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/server/src/server/router/api/v1/users/_userID/games/_game/_playtype/targets/milestones/router.ts b/server/src/server/router/api/v1/users/_userID/games/_game/_playtype/targets/milestones/router.ts
index e8e1fb120..ca2de9425 100644
--- a/server/src/server/router/api/v1/users/_userID/games/_game/_playtype/targets/milestones/router.ts
+++ b/server/src/server/router/api/v1/users/_userID/games/_game/_playtype/targets/milestones/router.ts
@@ -159,14 +159,17 @@ router.put(
 			});
 		}
 
-		const subResult = await SubscribeToMilestone(user.id, milestone);
+		const subResult = await SubscribeToMilestone(user.id, milestone, false);
 
-		if (subResult === SubscribeFailReasons.ALREADY_ACHIEVED) {
-			return res.status(400).json({
-				success: false,
-				description: `You cannot assign a milestone that would be immediately achieved.`,
-			});
-		}
+		// Users should be able to subscribe to milestones EVEN IF they would instantly
+		// achieve them.
+
+		// if (subResult === SubscribeFailReasons.ALREADY_ACHIEVED) {
+		// 	return res.status(400).json({
+		// 		success: false,
+		// 		description: `You cannot assign a milestone that would be immediately achieved.`,
+		// 	});
+		// }
 
 		if (subResult === SubscribeFailReasons.ALREADY_SUBSCRIBED) {
 			return res.status(409).json({