From 4eec8a77123ad6f5a90f1fefa84c5706d989655a Mon Sep 17 00:00:00 2001 From: zkldi Date: Sun, 9 May 2021 22:02:58 +0100 Subject: [PATCH] test todos --- .../framework/common/import-logger.test.ts | 20 +++++++++++++++++++ .../framework/milestones/milestones.test.ts | 12 +++++++++++ .../score-importing/hydrate-score.test.ts | 6 ++++++ .../score-importing/hydrate-score.ts | 3 +-- .../score-importing/score-importing.test.ts | 10 ++++++++++ .../score-importing/score-importing.ts | 2 +- .../sessions/name-generation.test.ts | 10 ++++++++++ .../sessions/performance-calc.test.ts | 6 ++++++ .../framework/sessions/sessions.test.ts | 10 ++++++++++ 9 files changed, 76 insertions(+), 3 deletions(-) create mode 100644 server/src/score-import/framework/common/import-logger.test.ts create mode 100644 server/src/score-import/framework/milestones/milestones.test.ts create mode 100644 server/src/score-import/framework/score-importing/hydrate-score.test.ts create mode 100644 server/src/score-import/framework/score-importing/score-importing.test.ts create mode 100644 server/src/score-import/framework/sessions/name-generation.test.ts create mode 100644 server/src/score-import/framework/sessions/performance-calc.test.ts create mode 100644 server/src/score-import/framework/sessions/sessions.test.ts diff --git a/server/src/score-import/framework/common/import-logger.test.ts b/server/src/score-import/framework/common/import-logger.test.ts new file mode 100644 index 000000000..b8f378174 --- /dev/null +++ b/server/src/score-import/framework/common/import-logger.test.ts @@ -0,0 +1,20 @@ +import t from "tap"; +import { CreateImportLoggerAndID } from "./import-logger"; +import { PublicUserDocument } from "kamaitachi-common"; +import { Logger } from "winston"; + +t.test("#CreateImportLoggerAndID", (t) => { + let { importID, logger } = CreateImportLoggerAndID( + { username: "foo", id: 1 } as PublicUserDocument, + "file/csv:eamusement-iidx" + ); + + t.match(importID, /^[a-f0-9]{40}$/u, "Should return a 40 character importID."); + + // not possible to automate this, probably. + logger.info( + "Namespaced log test - if this does not have 'file/csv:eamusement-iidx | foo (#1)' next to it, it's broke." + ); + + t.end(); +}); diff --git a/server/src/score-import/framework/milestones/milestones.test.ts b/server/src/score-import/framework/milestones/milestones.test.ts new file mode 100644 index 000000000..913e05e3b --- /dev/null +++ b/server/src/score-import/framework/milestones/milestones.test.ts @@ -0,0 +1,12 @@ +import t from "tap"; +import { CloseMongoConnection } from "../../../db/db"; +import ResetDBState from "../../../test-utils/reset-db-state"; +import { UpdateUsersMilestones } from "./milestones"; + +t.todo("#UpdateUsersMilestones", (t) => { + t.beforeEach(ResetDBState); + + t.end(); +}); + +t.teardown(CloseMongoConnection); diff --git a/server/src/score-import/framework/score-importing/hydrate-score.test.ts b/server/src/score-import/framework/score-importing/hydrate-score.test.ts new file mode 100644 index 000000000..7750b4295 --- /dev/null +++ b/server/src/score-import/framework/score-importing/hydrate-score.test.ts @@ -0,0 +1,6 @@ +import t from "tap"; +import { HydrateScore } from "./hydrate-score"; + +t.todo("#HydrateScore", (t) => { + t.end(); +}); diff --git a/server/src/score-import/framework/score-importing/hydrate-score.ts b/server/src/score-import/framework/score-importing/hydrate-score.ts index 3a63fb0df..d83f06876 100644 --- a/server/src/score-import/framework/score-importing/hydrate-score.ts +++ b/server/src/score-import/framework/score-importing/hydrate-score.ts @@ -5,7 +5,6 @@ import { ScoreDocument, AnySongDocument, } from "kamaitachi-common"; -import { Logger } from "winston"; import { DryScore, KtLogger } from "../../../types"; import { CreateCalculatedData } from "../calculated-data/calculated-data"; @@ -14,7 +13,7 @@ import { CreateCalculatedData } from "../calculated-data/calculated-data"; * @param dryScore The intermediate score to make into a real score. * @param userID The userID this score is for. */ -export default async function HydrateScore( +export async function HydrateScore( userID: integer, dryScore: DryScore, chart: AnyChartDocument, diff --git a/server/src/score-import/framework/score-importing/score-importing.test.ts b/server/src/score-import/framework/score-importing/score-importing.test.ts new file mode 100644 index 000000000..372f96474 --- /dev/null +++ b/server/src/score-import/framework/score-importing/score-importing.test.ts @@ -0,0 +1,10 @@ +import t from "tap"; +import { ImportAllIterableData, ImportIterableDatapoint } from "./score-importing"; + +t.todo("#ImportAllIterableData", (t) => { + t.end(); +}); + +t.todo("#ImportIterableDatapoint", (t) => { + t.end(); +}); diff --git a/server/src/score-import/framework/score-importing/score-importing.ts b/server/src/score-import/framework/score-importing/score-importing.ts index cad3afe76..5ae3099b2 100644 --- a/server/src/score-import/framework/score-importing/score-importing.ts +++ b/server/src/score-import/framework/score-importing/score-importing.ts @@ -6,7 +6,7 @@ import { AnySongDocument, } from "kamaitachi-common"; import { DryScore, ConverterFunction, ConverterFnReturn, KtLogger } from "../../../types"; -import HydrateScore from "./hydrate-score"; +import { HydrateScore } from "./hydrate-score"; import { InsertQueue, QueueScoreInsert, ScoreIDs } from "./insert-score"; import { ConverterFailure, diff --git a/server/src/score-import/framework/sessions/name-generation.test.ts b/server/src/score-import/framework/sessions/name-generation.test.ts new file mode 100644 index 000000000..ccde04a92 --- /dev/null +++ b/server/src/score-import/framework/sessions/name-generation.test.ts @@ -0,0 +1,10 @@ +import t from "tap"; +import { GenerateRandomSessionName } from "./name-generation"; + +t.test("#GenerateRandomSessionName", (t) => { + let res = GenerateRandomSessionName(); + + t.type(res, "string", "Should return a string."); + + t.end(); +}); diff --git a/server/src/score-import/framework/sessions/performance-calc.test.ts b/server/src/score-import/framework/sessions/performance-calc.test.ts new file mode 100644 index 000000000..3f5d91d92 --- /dev/null +++ b/server/src/score-import/framework/sessions/performance-calc.test.ts @@ -0,0 +1,6 @@ +import t from "tap"; +import { CreateSessionCalcData } from "./performance-calc"; + +t.todo("#CreateSessionCalcData", (t) => { + t.end(); +}); diff --git a/server/src/score-import/framework/sessions/sessions.test.ts b/server/src/score-import/framework/sessions/sessions.test.ts new file mode 100644 index 000000000..58a3f75dc --- /dev/null +++ b/server/src/score-import/framework/sessions/sessions.test.ts @@ -0,0 +1,10 @@ +import t from "tap"; +import { CreateSessions, LoadScoresIntoSessions } from "./sessions"; + +t.todo("#CreateSessions", (t) => { + t.end(); +}); + +t.todo("#LoadScoresIntoSessions", (t) => { + t.end(); +});