From 37d6cd0e25d793512d64d8c70da2bf293bf2b336 Mon Sep 17 00:00:00 2001 From: zkldi <20380519+zkldi@users.noreply.github.com> Date: Wed, 10 Nov 2021 17:44:32 +0000 Subject: [PATCH] Change status code to NOT_FOUND if no chart. --- server/src/server/router/ir/usc/router.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/server/src/server/router/ir/usc/router.ts b/server/src/server/router/ir/usc/router.ts index 55c09a6a4..8abc56142 100644 --- a/server/src/server/router/ir/usc/router.ts +++ b/server/src/server/router/ir/usc/router.ts @@ -143,12 +143,14 @@ router.get("/charts/:chartHash", RetrieveChart, (req, res) => { router.get("/charts/:chartHash/record", RetrieveChart, async (req, res) => { const chart = req[SYMBOL_TachiData]!.uscChartDoc; - // spec ambigious here - if (!chart) { return res.status(200).json({ - statusCode: STATUS_CODES.CHART_REFUSE, - description: "This IR is not currently tracking this chart.", + statusCode: STATUS_CODES.NOT_FOUND, + description: `This IR doesn't have any record data yet, or ${ + ServerConfig.USC_QUEUE_SIZE + } ${ + ServerConfig.USC_QUEUE_SIZE === 1 ? "person has" : "people have" + } not played the chart yet.`, }); }