From 1b7b482d79dcdf85d984c5d059799f5730dec8cf Mon Sep 17 00:00:00 2001 From: zkldi Date: Wed, 8 Sep 2021 09:44:48 +0100 Subject: [PATCH] CRITICAL: Fix bug where req.body was accidentally mutated --- server/src/server/middleware/request-logger.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/server/middleware/request-logger.ts b/server/src/server/middleware/request-logger.ts index 5ce769f4c..cf4e466b9 100644 --- a/server/src/server/middleware/request-logger.ts +++ b/server/src/server/middleware/request-logger.ts @@ -24,7 +24,7 @@ export const RequestLoggerMiddleware: RequestHandler = (req, res, next) => { // still, i don't like it. const safeBody = Object.prototype.hasOwnProperty.call(req.body, "password") - ? Object.assign(req.body, { password: "[OMITTED]" }) + ? Object.assign({}, req.body, { password: "[OMITTED]" }) : req.body; logger.debug(`Received request ${req.method} ${req.url}.`, {