From 19c76f8cdc5a4c5777e4f5bc130102be19937405 Mon Sep 17 00:00:00 2001
From: zkldi <20380519+zkldi@users.noreply.github.com>
Date: Wed, 10 Nov 2021 04:59:54 +0000
Subject: [PATCH] Remove pluralisation and tidy up embed fields

---
 server/src/lib/logger/discord-transport.ts | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/server/src/lib/logger/discord-transport.ts b/server/src/lib/logger/discord-transport.ts
index a08330887..fe91841f4 100644
--- a/server/src/lib/logger/discord-transport.ts
+++ b/server/src/lib/logger/discord-transport.ts
@@ -111,9 +111,16 @@ export default class DiscordTransport extends Transport {
 	private sendBucketData() {
 		let color = 0;
 
+		const fields = [];
+
 		for (const key of ["warn", "error"] as const) {
-			if (this.bucketData[key]) {
+			if (this.bucketData[key].length !== 0) {
 				color = DiscordColours[key];
+				fields.push({
+					// uppercase first char
+					name: key[0].toUpperCase() + key.slice(1),
+					value: this.bucketData[key].length,
+				});
 			}
 		}
 
@@ -130,10 +137,7 @@ export default class DiscordTransport extends Transport {
 			embeds: [
 				{
 					title: `${TachiConfig.NAME} Log Summary`,
-					fields: Object.entries(this.bucketData).map(([k, v]) => ({
-						name: k[0].toUpperCase() + k.slice(1) + (v.length === 1 ? "" : "s"),
-						value: v.length.toString(),
-					})),
+					fields,
 					description: `Log summary for ${this.bucketStart?.toUTCString()} to ${new Date().toUTCString()}.`,
 					color,
 					timestamp: new Date().toISOString(),