Debouncer::getStateFlag() and Debouncer::read() should be const #76

Closed
opened 2021-02-18 01:29:40 +03:00 by DanForever · 6 comments
DanForever commented 2021-02-18 01:29:40 +03:00 (Migrated from github.com)

It's causing a warning for me in the compiler:

warning: passing 'const Bounce2::Button' as 'this' argument discards qualifiers [-fpermissive]

I suspect the only reason this isn't a bigger issue is the default use of "-fpermissive"

It's causing a warning for me in the compiler: `warning: passing 'const Bounce2::Button' as 'this' argument discards qualifiers [-fpermissive]` I suspect the only reason this isn't a bigger issue is the default use of "-fpermissive"
thomasfredericks commented 2021-03-04 08:24:33 +03:00 (Migrated from github.com)

Hum, I do not understand. Could you elaborate? Mores specifically, I do not understand the relation between the title of the issue and your description.

Hum, I do not understand. Could you elaborate? Mores specifically, I do not understand the relation between the title of the issue and your description.
DanForever commented 2021-03-04 12:02:11 +03:00 (Migrated from github.com)

The library needs a bit of const-correctness love. If you need I can create a pull request showing what I mean

The library needs a bit of const-correctness love. If you need I can create a pull request showing what I mean
thomasfredericks commented 2021-03-04 20:33:51 +03:00 (Migrated from github.com)

Sure.

Sure.
DanForever commented 2021-03-04 21:18:47 +03:00 (Migrated from github.com)

Pull request made: #78

Pull request made: #78
thomasfredericks commented 2021-03-04 23:57:22 +03:00 (Migrated from github.com)

Was merged. Thank you.

Was merged. Thank you.
DanForever commented 2021-03-05 01:20:04 +03:00 (Migrated from github.com)

Glad I could help :)

Glad I could help :)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/thomasfredericks_Bounce2#76