when the attribute that they concern is protected?
protected:
uint8_t state;
I'm not sure it makes sense to be more restrictive of the methods than the underlying attribute.
Why are the following methods all private:
```
private:
inline void changeState();
inline void setStateFlag(const uint8_t flag) {state |= flag;}
inline void unsetStateFlag(const uint8_t flag) {state &= ~flag;}
inline void toggleStateFlag(const uint8_t flag) {state ^= flag;}
inline bool getStateFlag(const uint8_t flag) {return((state & flag) != 0);}
```
when the attribute that they concern is protected?
```
protected:
uint8_t state;
```
I'm not sure it makes sense to be more restrictive of the methods than the underlying attribute.
This is just an oversight. I will look into this when I come back from vacation. I want to split the debouncing code from the hardware layer at the same time.
This is just an oversight. I will look into this when I come back from vacation. I want to split the debouncing code from the hardware layer at the same time.
@jamesmyatt Those methods are private because they might change in the future. They are linked to space saving and not to the functioning of the algorithm. Anyways, I merged a lot of changes.
@jamesmyatt Those methods are private because they might change in the future. They are linked to space saving and not to the functioning of the algorithm. Anyways, I merged a lot of changes.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Why are the following methods all private:
when the attribute that they concern is protected?
I'm not sure it makes sense to be more restrictive of the methods than the underlying attribute.
This is just an oversight. I will look into this when I come back from vacation. I want to split the debouncing code from the hardware layer at the same time.
@jamesmyatt Those methods are private because they might change in the future. They are linked to space saving and not to the functioning of the algorithm. Anyways, I merged a lot of changes.