@PaintYourDragon late to the party, but there is a typo, this should be DP/DM (not DN though). Since we need to make an PR to correct it, do you think we should rename them to PIN_USB_HOST_DP/DM to make it clearer that this is for host. Since I saw some other board has the same naming but for usb device ?
@PaintYourDragon late to the party, but there is a typo, this should be DP/DM (not DN though). Since we need to make an PR to correct it, do you think we should rename them to PIN_USB_HOST_DP/DM to make it clearer that this is for host. Since I saw some other board has the same naming but for usb device ?
Good idea, I’ll add HOST in the pin names, and DM instead of DN (I was probably following the lead of the DVI Feather, where it’s [N]egative. Boards are not quite shipping to customers yet so the changes shouldn’t affect anyone.
Good idea, I’ll add HOST in the pin names, and DM instead of DN (I was probably following the lead of the DVI Feather, where it’s [N]egative. Boards are not quite shipping to customers yet so the changes shouldn’t affect anyone.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
ThinkINK (e-paper display) and USB Host.
Neat! You guys are coming out with a ton of cool boards.
Is this PR ready to merge or are you expecting more changes/additions?
I think that’s it for this round (add RFM, ThinkINK & USB host, fix SCORPIO & DVI pins). Might be more in the future but probably not for some weeks.
@@ -0,0 +15,4 @@// USB host connector#define PIN_USB_DP (16u)#define PIN_USB_DN (17u)@PaintYourDragon late to the party, but there is a typo, this should be DP/DM (not DN though). Since we need to make an PR to correct it, do you think we should rename them to PIN_USB_HOST_DP/DM to make it clearer that this is for host. Since I saw some other board has the same naming but for usb device ?
@@ -0,0 +15,4 @@// USB host connector#define PIN_USB_DP (16u)#define PIN_USB_DN (17u)Good idea, I’ll add HOST in the pin names, and DM instead of DN (I was probably following the lead of the DVI Feather, where it’s [N]egative. Boards are not quite shipping to customers yet so the changes shouldn’t affect anyone.