Max/djhackersdev_minime
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Chunithm Amazon Plus fixup - [merged] #31

New Issue
Closed
opened 2020-12-15 09:57:22 +03:00 by icex2 · 7 comments
icex2 commented 2020-12-15 09:57:22 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Felix on Dec 15, 2020, 07:57

Merges amazon-plus -> master

Chunithm Amazon Plus calls an API method named GetUserFavoriteMusicApi. I asked a few players that are more familiar with the game than I am and there is no functionality in-game or on the official Chunithm web portal to set a profile's favorites, so I decided that a stub method is appropriate at this time.

In GitLab by @Felix on Dec 15, 2020, 07:57 _Merges amazon-plus -> master_ Chunithm Amazon Plus calls an API method named `GetUserFavoriteMusicApi`. I asked a few players that are more familiar with the game than I am and there is no functionality in-game or on the official Chunithm web portal to set a profile's favorites, so I decided that a stub method is appropriate at this time.
icex2 commented 2020-12-15 23:53:00 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tau on Dec 15, 2020, 21:53

Commented on src/chunithm/handler/index.ts line 129

Leftover debug code

In GitLab by @tau on Dec 15, 2020, 21:53 Commented on [src/chunithm/handler/index.ts line 129](https://github.com/djhackersdev/minime/compare/bf390f15e2ba81ef2fdeb73cc31016dee0b87f04..4485b9568e89c98f09e4fb6a0c07f3dfef5a42d8#diff-07d771065f46c453a36804aaa7cb39acR129) Leftover debug code
icex2 commented 2020-12-16 01:53:11 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Felix on Dec 15, 2020, 23:53

Commented on src/chunithm/handler/index.ts line 129

Oops, you are correct!

In GitLab by @Felix on Dec 15, 2020, 23:53 Commented on [src/chunithm/handler/index.ts line 129](https://github.com/djhackersdev/minime/compare/bf390f15e2ba81ef2fdeb73cc31016dee0b87f04..4485b9568e89c98f09e4fb6a0c07f3dfef5a42d8#diff-07d771065f46c453a36804aaa7cb39acR129) Oops, you are correct!
icex2 commented 2020-12-16 01:56:55 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Felix on Dec 15, 2020, 23:56

added 1 commit

  • f077a9d6 - chunithm: stub GetUserFavoriteMusicApi

Compare with previous version

In GitLab by @Felix on Dec 15, 2020, 23:56 added 1 commit <ul><li>f077a9d6 - chunithm: stub GetUserFavoriteMusicApi</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/23/diffs?diff_id=1369&start_sha=4485b9568e89c98f09e4fb6a0c07f3dfef5a42d8)
icex2 commented 2020-12-16 01:56:55 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Felix on Dec 15, 2020, 23:56

Commented on src/chunithm/handler/index.ts line 129

changed this line in version 2 of the diff

In GitLab by @Felix on Dec 15, 2020, 23:56 Commented on [src/chunithm/handler/index.ts line 129](https://github.com/djhackersdev/minime/compare/bf390f15e2ba81ef2fdeb73cc31016dee0b87f04..4485b9568e89c98f09e4fb6a0c07f3dfef5a42d8#diff-07d771065f46c453a36804aaa7cb39acR129) changed this line in [version 2 of the diff](/djhackers/minime/-/merge_requests/23/diffs?diff_id=1369&start_sha=4485b9568e89c98f09e4fb6a0c07f3dfef5a42d8#1480ddfebd8e3f1e64158ea45b7058863f923891_129_129)
icex2 commented 2020-12-16 01:56:59 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Felix on Dec 15, 2020, 23:56

resolved all threads

In GitLab by @Felix on Dec 15, 2020, 23:56 resolved all threads
icex2 commented 2020-12-16 01:58:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tau on Dec 15, 2020, 23:58

LGTM, please rebase on the current state of master and I'll merge.

In GitLab by @tau on Dec 15, 2020, 23:58 LGTM, please rebase on the current state of master and I'll merge.
icex2 commented 2020-12-16 01:59:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Felix on Dec 15, 2020, 23:59

added 10 commits

  • f077a9d6...87d83c5c - 9 commits from branch djhackers:master
  • 872ee2d1 - chunithm: stub GetUserFavoriteMusicApi

Compare with previous version

In GitLab by @Felix on Dec 15, 2020, 23:59 added 10 commits <ul><li>f077a9d6...87d83c5c - 9 commits from branch <code>djhackers:master</code></li><li>872ee2d1 - chunithm: stub GetUserFavoriteMusicApi</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/23/diffs?diff_id=1370&start_sha=f077a9d619d1ccc233429f35d7c667d0de337628)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_minime#31