chuni: team feature & remove information event id - [closed] #38

Closed
opened 2021-02-11 07:07:19 +03:00 by icex2 · 7 comments
icex2 commented 2021-02-11 07:07:19 +03:00 (Migrated from github.com)

In GitLab by @esterTion on Feb 11, 2021, 05:07

Merges 1.40 -> master

Adds 4 api endpoints:
GetUserFavoriteItemApi
GetUserRivalDataApi (Seems unused)
GetUserRivalMusicApi (Seems unused)
GetUserTeamApi

Changed GetUserPreviewApi, now added a chargeState: "1" to indicate player has chunithm standard course monthly subscription service, which is required to use team feature
Team name is customizable through .env file, with CHUNITHM_TEAM_NAME="team name here"

Changed static/event.ts, deleted all the information events so that when using omnimix, new registered player won't need to click over all the informations from past several years

In GitLab by @esterTion on Feb 11, 2021, 05:07 _Merges 1.40 -> master_ Adds 4 api endpoints: `GetUserFavoriteItemApi` `GetUserRivalDataApi` (Seems unused) `GetUserRivalMusicApi` (Seems unused) `GetUserTeamApi` Changed `GetUserPreviewApi`, now added a `chargeState: "1"` to indicate player has `chunithm standard course` monthly subscription service, which is required to use team feature Team name is customizable through `.env` file, with `CHUNITHM_TEAM_NAME="team name here"` Changed `static/event.ts`, deleted all the information events so that when using omnimix, new registered player won't need to click over all the informations from past several years
icex2 commented 2021-02-13 11:08:57 +03:00 (Migrated from github.com)

In GitLab by @Felix on Feb 13, 2021, 09:08

I redid the event handling in !29 so only events present for a given Chunithm version are sent back.

In GitLab by @Felix on Feb 13, 2021, 09:08 I redid the event handling in !29 so only events present for a given Chunithm version are sent back.
icex2 commented 2021-02-13 11:38:26 +03:00 (Migrated from github.com)

In GitLab by @esterTion on Feb 13, 2021, 09:38

Yeah... I saw your merge after created this one.
I personally play this game with a custom made option data, which adds back all the events from every previous version, so have a full list of event ids is pretty useful.
Not sure how to handle the conflict now though

In GitLab by @esterTion on Feb 13, 2021, 09:38 Yeah... I saw your merge after created this one. I personally play this game with a custom made option data, which adds back all the events from every previous version, so have a full list of event ids is pretty useful. Not sure how to handle the conflict now though
icex2 commented 2021-02-13 11:45:31 +03:00 (Migrated from github.com)

In GitLab by @Felix on Feb 13, 2021, 09:45

For changing commits that I've already done, I do a git rebase -i <source branch> or git rebase -i <commit hash to edit>^ to interactively select which commits I want to edit. Then you can do a force push to forcibly update your branch on the remote side since rebasing will cause your local branch to diverge from the branch on the remote Git repository.

In GitLab by @Felix on Feb 13, 2021, 09:45 For changing commits that I've already done, I do a `git rebase -i <source branch>` or `git rebase -i <commit hash to edit>^` to interactively select which commits I want to edit. Then you can do a force push to forcibly update your branch on the remote side since rebasing will cause your local branch to diverge from the branch on the remote Git repository.
icex2 commented 2021-02-13 11:54:53 +03:00 (Migrated from github.com)

In GitLab by @esterTion on Feb 13, 2021, 09:54

Nah I'm not saying about how to reset git.
Talking about two different event dispatch method.

Your change just sends event in one specific version, though I prefer just place all the data in the latest version.
That is the main conflict at this point

In GitLab by @esterTion on Feb 13, 2021, 09:54 Nah I'm not saying about how to reset git. Talking about two different event dispatch method. Your change just sends event in one specific version, though I prefer just place all the data in the latest version. That is the main conflict at this point
icex2 commented 2021-02-19 16:26:23 +03:00 (Migrated from github.com)

In GitLab by @seika1 on Feb 19, 2021, 14:26

Commented on src/chunithm/handler/getUserTeam.ts line 16

if there's no team specified setting teamId to "0" should prevent the team thing from showing up

In GitLab by @seika1 on Feb 19, 2021, 14:26 Commented on [src/chunithm/handler/getUserTeam.ts line 16](https://github.com/djhackersdev/minime/compare/86c7ae272d2c6ca50474175677bf1f693e000ca7..0d24e9147c9395d8a28907a2eafe750202cda400#diff-dc6bdd38f406b35d290dd42ff85cad7bR16) if there's no team specified setting teamId to "0" should prevent the team thing from showing up
icex2 commented 2021-02-19 16:28:18 +03:00 (Migrated from github.com)

In GitLab by @seika1 on Feb 19, 2021, 14:28

Commented on src/chunithm/handler/getUserTeam.ts line 18

supposedly past me determined this was another object?

https://dev.s-ul.net/djhackers/minime/-/merge_requests/32/diffs?commit_id=f9786aced4bc334816d7a13ee4ad7d2c755cc995#dd5f70eb5eac90b50e08dd7c9015a1f6a0e404c0_0_9

no idea how much faith to put into past me, though...

In GitLab by @seika1 on Feb 19, 2021, 14:28 Commented on [src/chunithm/handler/getUserTeam.ts line 18](https://github.com/djhackersdev/minime/compare/86c7ae272d2c6ca50474175677bf1f693e000ca7..0d24e9147c9395d8a28907a2eafe750202cda400#diff-dc6bdd38f406b35d290dd42ff85cad7bR18) supposedly past me determined this was another object? https://dev.s-ul.net/djhackers/minime/-/merge_requests/32/diffs?commit_id=f9786aced4bc334816d7a13ee4ad7d2c755cc995#dd5f70eb5eac90b50e08dd7c9015a1f6a0e404c0_0_9 no idea how much faith to put into past me, though...
icex2 commented 2021-02-19 17:09:11 +03:00 (Migrated from github.com)

In GitLab by @esterTion on Feb 19, 2021, 15:09

Commented on src/chunithm/handler/getUserTeam.ts line 18

oh, i didn't dig deep enough, i guess you are right

In GitLab by @esterTion on Feb 19, 2021, 15:09 Commented on [src/chunithm/handler/getUserTeam.ts line 18](https://github.com/djhackersdev/minime/compare/86c7ae272d2c6ca50474175677bf1f693e000ca7..0d24e9147c9395d8a28907a2eafe750202cda400#diff-dc6bdd38f406b35d290dd42ff85cad7bR18) oh, i didn't dig deep enough, i guess you are right
Sign in to join this conversation.