Max/djhackersdev_minime
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

DIVA support - [opened] #34

New Issue
Open
opened 2021-01-05 22:52:06 +03:00 by icex2 · 20 comments
icex2 commented 2021-01-05 22:52:06 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 5, 2021, 20:52

Merges master -> master

Added partial support which only allows the player to run the game without hex edit.
The server will return true to all requests and show OK to all network check.

Aime support is not working but it's a good start.

In GitLab by @WRShooter on Jan 5, 2021, 20:52 _Merges master -> master_ Added partial support which only allows the player to run the game without hex edit. The server will return true to all requests and show OK to all network check. Aime support is not working but it's a good start.
icex2 commented 2021-01-05 22:52:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 5, 2021, 20:52

marked this merge request as draft

In GitLab by @WRShooter on Jan 5, 2021, 20:52 marked this merge request as **draft**
icex2 commented 2021-01-05 23:22:00 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 5, 2021, 21:22

marked this merge request as ready

In GitLab by @WRShooter on Jan 5, 2021, 21:22 marked this merge request as **ready**
icex2 commented 2021-01-06 01:31:44 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 5, 2021, 23:31

added 1 commit

  • 8a1ee9fb - Forgot one request

Compare with previous version

In GitLab by @WRShooter on Jan 5, 2021, 23:31 added 1 commit <ul><li>8a1ee9fb - Forgot one request</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1421&start_sha=993679437653bca8537f8eaffffad0c6e4aee089)
icex2 commented 2021-01-06 01:41:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tau on Jan 5, 2021, 23:41

This MR looks good in principle although it will need a bit of reformatting before I can merge it. Please run Prettier over this code so that it conforms to the existing codebase's formatting standards. Also there is no need to wrap the handler functions in classes; the existing handlers in the other game services are implemented as stateless functions.

In GitLab by @tau on Jan 5, 2021, 23:41 This MR looks good in principle although it will need a bit of reformatting before I can merge it. Please run Prettier over this code so that it conforms to the existing codebase's formatting standards. Also there is no need to wrap the handler functions in classes; the existing handlers in the other game services are implemented as stateless functions.
icex2 commented 2021-01-06 02:05:13 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:05

I really liked to have in classes as it is easier to read in general

Regarding Prettier, I'll run it next hour

In GitLab by @WRShooter on Jan 6, 2021, 24:05 I really liked to have in classes as it is easier to read in general Regarding Prettier, I'll run it next hour
icex2 commented 2021-01-06 02:28:51 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:28

added 1 commit

  • a53e8b70 - Update index.ts - Ran Prettier

Compare with previous version

In GitLab by @WRShooter on Jan 6, 2021, 24:28 added 1 commit <ul><li>a53e8b70 - Update index.ts - Ran Prettier</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1422&start_sha=8a1ee9fb2d4edcae9c35e3893fdcdfdee052ea32)
icex2 commented 2021-01-06 02:29:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:29

added 1 commit

  • d8f7e64c - Update bin.ts - Ran Prettier

Compare with previous version

In GitLab by @WRShooter on Jan 6, 2021, 24:29 added 1 commit <ul><li>d8f7e64c - Update bin.ts - Ran Prettier</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1423&start_sha=a53e8b70e2256281d2d7960f5de23f1de4149ec6)
icex2 commented 2021-01-06 02:30:07 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:30

added 1 commit

  • b2a54b31 - Update card.ts - Ran Prettier

Compare with previous version

In GitLab by @WRShooter on Jan 6, 2021, 24:30 added 1 commit <ul><li>b2a54b31 - Update card.ts - Ran Prettier</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1424&start_sha=d8f7e64ce0246cf201f4a8d818ef9ed0bf2e443c)
icex2 commented 2021-01-06 02:30:31 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:30

added 1 commit

  • be7c60d9 - Update databank.ts - Ran Prettier

Compare with previous version

In GitLab by @WRShooter on Jan 6, 2021, 24:30 added 1 commit <ul><li>be7c60d9 - Update databank.ts - Ran Prettier</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1425&start_sha=b2a54b31c97703b43c2638205009e96cbe3957e7)
icex2 commented 2021-01-06 02:30:57 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:30

added 1 commit

  • 8d5f4e94 - Update ingame.ts - Ran Prettier

Compare with previous version

In GitLab by @WRShooter on Jan 6, 2021, 24:30 added 1 commit <ul><li>8d5f4e94 - Update ingame.ts - Ran Prettier</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1426&start_sha=be7c60d9b0e6ccbbd460e8bf0acce4145ed0cbb1)
icex2 commented 2021-01-06 02:32:01 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Jan 6, 2021, 24:32

Alright I got it running and rechecked with npx prettier --check .\src\diva\handler*.* and npx prettier --check .\src\diva*.* which both confirmed it is good

In GitLab by @WRShooter on Jan 6, 2021, 24:32 Alright I got it running and rechecked with npx prettier --check .\src\diva\handler\*.* and npx prettier --check .\src\diva\*.* which both confirmed it is good
icex2 commented 2021-02-14 00:26:27 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:26

added 1 commit

  • 25db29c4 - Update card.ts - Adding dummy profile id

Compare with previous version

In GitLab by @WRShooter on Feb 13, 2021, 22:26 added 1 commit <ul><li>25db29c4 - Update card.ts - Adding dummy profile id</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1494&start_sha=8d5f4e94cab0473c19fa69589937f4f3bada078f)
icex2 commented 2021-02-14 00:28:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:28

added 1 commit

  • c74ebb43 - Adding dummy user profile with static values, to be modified for database support

Compare with previous version

In GitLab by @WRShooter on Feb 13, 2021, 22:28 added 1 commit <ul><li>c74ebb43 - Adding dummy user profile with static values, to be modified for database support</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1495&start_sha=25db29c4b165f34e739f7791dc7a8579f4343a98)
icex2 commented 2021-02-14 00:30:18 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:30

added 1 commit

  • 3159741d - Update index.ts for dummy profile requests

Compare with previous version

In GitLab by @WRShooter on Feb 13, 2021, 22:30 added 1 commit <ul><li>3159741d - Update index.ts for dummy profile requests</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1496&start_sha=c74ebb430858ed9a10feb8caad6b2360a0eb0619)
icex2 commented 2021-02-14 00:35:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:35

added 1 commit

  • 1054e516 - Update ingame.ts - Adding dummy profile to the stage result

Compare with previous version

In GitLab by @WRShooter on Feb 13, 2021, 22:35 added 1 commit <ul><li>1054e516 - Update ingame.ts - Adding dummy profile to the stage result </li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1497&start_sha=3159741d35f15b1b0a62c403e8bc904805d225f0)
icex2 commented 2021-02-14 00:37:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:37

added 1 commit

  • 6a0bc043 - Update user.ts - Ran Prettier

Compare with previous version

In GitLab by @WRShooter on Feb 13, 2021, 22:37 added 1 commit <ul><li>6a0bc043 - Update user.ts - Ran Prettier</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1498&start_sha=1054e51688b4ba1993e994d32e856530a2f583fa)
icex2 commented 2021-02-14 00:39:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:39

added 1 commit

  • 84e26958 - Update databank.ts - Fixing quest info

Compare with previous version

In GitLab by @WRShooter on Feb 13, 2021, 22:39 added 1 commit <ul><li>84e26958 - Update databank.ts - Fixing quest info</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1499&start_sha=6a0bc0431a74e4cfb0ac085b95ada40331b0a7fa)
icex2 commented 2021-02-14 00:46:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 13, 2021, 22:46

I just added a dummy profile to diva where you can use a card and it will show that dummy profile and load just fine.
This way the game is playable with even a card reader but this will not do score saving.

I am still trying to determine how to read the values to get scores to save at all based on the song ID but it is more difficult than i expected

In GitLab by @WRShooter on Feb 13, 2021, 22:46 I just added a dummy profile to diva where you can use a card and it will show that dummy profile and load just fine. This way the game is playable with even a card reader but this will not do score saving. I am still trying to determine how to read the values to get scores to save at all based on the song ID but it is more difficult than i expected
icex2 commented 2021-02-21 04:52:47 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 21, 2021, 02:52

added 1 commit

  • 3aa1f886 - Removed the bin request, it is invalid

Compare with previous version

In GitLab by @WRShooter on Feb 21, 2021, 02:52 added 1 commit <ul><li>3aa1f886 - Removed the bin request, it is invalid</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1509&start_sha=84e26958496384b5df7b6d649dd6a7df9d07ea03)
icex2 commented 2021-02-21 04:53:05 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @WRShooter on Feb 21, 2021, 02:53

added 1 commit

  • aaaf18ad - Delete bin.ts

Compare with previous version

In GitLab by @WRShooter on Feb 21, 2021, 02:53 added 1 commit <ul><li>aaaf18ad - Delete bin.ts</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/26/diffs?diff_id=1510&start_sha=3aa1f8865e43bd6e51fa870a9b43a620e0fca5d9)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_minime#34