The current implementation of getUserRecentRating, which pulls from the last 30 scores in the play log, isn't quite correct: for example, I've noticed
differences in rating after finishing the last song on a play => logging in afterwards
in upsertUserAll, not all recently played scores are added to userRecentRatingList
This MR adds a new table cm_user_recent_rating that just stores whatever the client sends as userRecentRatingList directly, along with a migration that dumps the last 30 scores (with rudimentary filtering) from the play log into this new table to avoid a rating crash.
In GitLab by @seika1 on Jul 31, 2020, 07:46
_Merges fix-recent-rating-2 -> master_
The current implementation of `getUserRecentRating`, which pulls from the last 30 scores in the play log, isn't quite correct: for example, I've noticed
* differences in rating after finishing the last song on a play => logging in afterwards
* in `upsertUserAll`, not all recently played scores are added to `userRecentRatingList`
This MR adds a new table `cm_user_recent_rating` that just stores whatever the client sends as `userRecentRatingList` directly, along with a migration that dumps the last 30 scores (with rudimentary filtering) from the play log into this new table to avoid a rating crash.
In GitLab by @seika1 on Aug 2, 2020, 05:40
added 7 commits
<ul><li>0b5c3cdc...e90068f3 - 6 commits from branch <code>djhackers:master</code></li><li>838b2586 - chuni: Correctly implement recent rating requests</li></ul>
[Compare with previous version](/djhackers/minime/-/merge_requests/16/diffs?diff_id=1263&start_sha=0b5c3cdc046a12a8a968de6346f70a7b0c91c0a7)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @seika1 on Jul 31, 2020, 07:46
Merges fix-recent-rating-2 -> master
The current implementation of
getUserRecentRating, which pulls from the last 30 scores in the play log, isn't quite correct: for example, I've noticedupsertUserAll, not all recently played scores are added touserRecentRatingListThis MR adds a new table
cm_user_recent_ratingthat just stores whatever the client sends asuserRecentRatingListdirectly, along with a migration that dumps the last 30 scores (with rudimentary filtering) from the play log into this new table to avoid a rating crash.In GitLab by @seika1 on Jul 31, 2020, 07:49
added 1 commit
Compare with previous version
In GitLab by @seika1 on Aug 2, 2020, 05:40
added 7 commits
djhackers:masterCompare with previous version
In GitLab by @tau on Aug 2, 2020, 18:27
Rebased and merged manually
In GitLab by @tau on Aug 2, 2020, 18:27
closed