Max/djhackersdev_minime
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

New felica lookup - [closed] #21

New Issue
Closed
opened 2020-06-10 11:49:44 +03:00 by icex2 · 5 comments
icex2 commented 2020-06-10 11:49:44 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @cxm on Jun 10, 2020, 10:49

Merges new-felica-lookup -> master

amusement IC support

In GitLab by @cxm on Jun 10, 2020, 10:49 _Merges new-felica-lookup -> master_ amusement IC support
icex2 commented 2020-06-10 19:58:16 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tau on Jun 10, 2020, 18:58

Commented on src/aimedb/decoder.ts line 104

Please keep this list of insertions sorted by command ID. The reader function should probably also be renamed to readFeliCaLookupRequest2 for consistency with the naming of readLookupRequest2

Merge request looks good otherwise.

In GitLab by @tau on Jun 10, 2020, 18:58 Commented on [src/aimedb/decoder.ts line 104](https://github.com/djhackersdev/minime/compare/b989ad22a2083d39fd8a26d2fa03d3977f8ff517..d3e5220b611888c016aa5ef836d0513e0e086a51#diff-7f6f738011e26617c389e7346a308405R104) Please keep this list of insertions sorted by command ID. The reader function should probably also be renamed to `readFeliCaLookupRequest2` for consistency with the naming of `readLookupRequest2` Merge request looks good otherwise.
icex2 commented 2020-07-22 05:47:46 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @cxm on Jul 22, 2020, 04:47

Commented on src/aimedb/decoder.ts line 104

changed this line in version 2 of the diff

In GitLab by @cxm on Jul 22, 2020, 04:47 Commented on [src/aimedb/decoder.ts line 104](https://github.com/djhackersdev/minime/compare/b989ad22a2083d39fd8a26d2fa03d3977f8ff517..d3e5220b611888c016aa5ef836d0513e0e086a51#diff-7f6f738011e26617c389e7346a308405R104) changed this line in [version 2 of the diff](/djhackers/minime/-/merge_requests/13/diffs?diff_id=1258&start_sha=d3e5220b611888c016aa5ef836d0513e0e086a51#8c566aac581fecef667d8749a9071bc791de305a_104_104)
icex2 commented 2020-07-22 05:47:47 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @cxm on Jul 22, 2020, 04:47

added 1 commit

  • 432feea0 - chuni: fix felica lookup2 (by felix)

Compare with previous version

In GitLab by @cxm on Jul 22, 2020, 04:47 added 1 commit <ul><li>432feea0 - chuni: fix felica lookup2 (by felix)</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/13/diffs?diff_id=1258&start_sha=d3e5220b611888c016aa5ef836d0513e0e086a51)
icex2 commented 2020-08-01 20:03:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tau on Aug 1, 2020, 19:03

Squashed the fixup commits into a single commit and merged manually. Sorry for the delay.

In GitLab by @tau on Aug 1, 2020, 19:03 Squashed the fixup commits into a single commit and merged manually. Sorry for the delay.
icex2 commented 2020-08-01 20:03:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tau on Aug 1, 2020, 19:03

closed

In GitLab by @tau on Aug 1, 2020, 19:03 closed
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_minime#21