Chunithm: Enable all events and fix item pagination issue - [merged] #16

Closed
opened 2020-02-17 09:54:14 +03:00 by icex2 · 9 comments
icex2 commented 2020-02-17 09:54:14 +03:00 (Migrated from github.com)

In GitLab by @Felix on Feb 17, 2020, 07:54

Merges chunithm -> master

This merge request adds all event ids to enable Chunithm Amazon features such as local matching, Chunithm Duel, quests, and other unlocking features. This issue also fixes item pagination for when you have over 600 items for an item type (like those 1400+ name plate tag lines).

Also, Ongeki seems to use a similar network API as Chunithm except with actual JSON types instead of stringify-ing all values and I managed to figure out how the maintenance timer is set for Ongeki. I ported that fix over to Chunithm with one change that sets the start time an hour before the end time.

In GitLab by @Felix on Feb 17, 2020, 07:54 _Merges chunithm -> master_ This merge request adds all event ids to enable Chunithm Amazon features such as local matching, Chunithm Duel, quests, and other unlocking features. This issue also fixes item pagination for when you have over 600 items for an item type (like those 1400+ name plate tag lines). Also, Ongeki seems to use a similar network API as Chunithm except with actual JSON types instead of stringify-ing all values and I managed to figure out how the maintenance timer is set for Ongeki. I ported that fix over to Chunithm with one change that sets the start time an hour before the end time.
icex2 commented 2020-02-17 17:43:43 +03:00 (Migrated from github.com)

In GitLab by @tau on Feb 17, 2020, 15:43

Commented on src/chunithm/handler/getGameEvent.ts line 10

Dealing with nontrivial static data sets is going to be tricky, especially once we get around to supporting multiple versions of chunithm. We'll have to come up with a more sophisticated approach later, but for the time being let's try using this:

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html#new---resolvejsonmodule

and putting the bare array into a ../static/event.json file or something like that, which can then be imported into this module.

In GitLab by @tau on Feb 17, 2020, 15:43 Commented on [src/chunithm/handler/getGameEvent.ts line 10](https://github.com/djhackersdev/minime/compare/908ceaf378a6200790316beb2231972836625de9..35ea1ab8c3c8259039c33a523e5a672b86e12e52#diff-cf9879c5b2dc9bcc855e632895c4c1b1R10) Dealing with nontrivial static data sets is going to be tricky, especially once we get around to supporting multiple versions of chunithm. We'll have to come up with a more sophisticated approach later, but for the time being let's try using this: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html#new---resolvejsonmodule and putting the bare array into a `../static/event.json` file or something like that, which can then be `import`ed into this module.
icex2 commented 2020-02-18 02:57:59 +03:00 (Migrated from github.com)

In GitLab by @Felix on Feb 18, 2020, 24:57

Commented on src/chunithm/handler/getGameEvent.ts line 10

Will do. The main way I think MiniMe can handle multiple versions is to have a version endpoint returned when the game boots up and requests the URI on Allnet startup.

In GitLab by @Felix on Feb 18, 2020, 24:57 Commented on [src/chunithm/handler/getGameEvent.ts line 10](https://github.com/djhackersdev/minime/compare/908ceaf378a6200790316beb2231972836625de9..35ea1ab8c3c8259039c33a523e5a672b86e12e52#diff-cf9879c5b2dc9bcc855e632895c4c1b1R10) Will do. The main way I think MiniMe can handle multiple versions is to have a version endpoint returned when the game boots up and requests the URI on Allnet startup.
icex2 commented 2020-03-06 13:30:43 +03:00 (Migrated from github.com)

In GitLab by @Felix on Mar 6, 2020, 11:30

Commented on src/chunithm/handler/getGameEvent.ts line 10

changed this line in version 2 of the diff

In GitLab by @Felix on Mar 6, 2020, 11:30 Commented on [src/chunithm/handler/getGameEvent.ts line 10](https://github.com/djhackersdev/minime/compare/908ceaf378a6200790316beb2231972836625de9..35ea1ab8c3c8259039c33a523e5a672b86e12e52#diff-cf9879c5b2dc9bcc855e632895c4c1b1R10) changed this line in [version 2 of the diff](/djhackers/minime/-/merge_requests/8/diffs?diff_id=1163&start_sha=35ea1ab8c3c8259039c33a523e5a672b86e12e52#54fb96b52ba0079570925c3c982ccdec5064ddbb_10_11)
icex2 commented 2020-03-06 13:30:43 +03:00 (Migrated from github.com)

In GitLab by @Felix on Mar 6, 2020, 11:30

added 1 commit

  • 28dd6647 - chuni: Put event IDs in separate static file

Compare with previous version

In GitLab by @Felix on Mar 6, 2020, 11:30 added 1 commit <ul><li>28dd6647 - chuni: Put event IDs in separate static file</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/8/diffs?diff_id=1163&start_sha=35ea1ab8c3c8259039c33a523e5a672b86e12e52)
icex2 commented 2020-03-06 14:00:33 +03:00 (Migrated from github.com)

In GitLab by @Felix on Mar 6, 2020, 12:00

I checked the EventSort.xml file and noticed there are events that do not have an event folder. I'll add them in a bit.

In GitLab by @Felix on Mar 6, 2020, 12:00 I checked the `EventSort.xml` file and noticed there are events that do not have an event folder. I'll add them in a bit.
icex2 commented 2020-03-18 22:29:55 +03:00 (Migrated from github.com)

In GitLab by @Felix on Mar 18, 2020, 20:29

added 2 commits

  • b4c4d9d3 - chunithm: Add remaining Chunithm Amazon event IDs
  • 42b71cf8 - chunithm: Fix maintenance timer

Compare with previous version

In GitLab by @Felix on Mar 18, 2020, 20:29 added 2 commits <ul><li>b4c4d9d3 - chunithm: Add remaining Chunithm Amazon event IDs</li><li>42b71cf8 - chunithm: Fix maintenance timer</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/8/diffs?diff_id=1167&start_sha=28dd66474cd4ca4a82f30a52cc4cdcc01f66d277)
icex2 commented 2020-03-19 00:40:42 +03:00 (Migrated from github.com)

In GitLab by @Felix on Mar 18, 2020, 22:40

Alright, I added the remaining events and some more stuff showed up including all the news items.

In GitLab by @Felix on Mar 18, 2020, 22:40 Alright, I added the remaining events and some more stuff showed up including all the news items.
icex2 commented 2020-03-23 02:16:31 +03:00 (Migrated from github.com)

In GitLab by @Felix on Mar 23, 2020, 24:16

added 6 commits

  • 6947912d - 1 commit from branch djhackers:master
  • 3b7f3ce8 - chuni: Prevent recursive item calls if user has more than 600 items
  • 649dbe8e - chuni: Enable all events
  • a1cf5f60 - chuni: Put event IDs in separate static file
  • e53edc29 - chuni: Add remaining Chunithm Amazon event IDs
  • 74997786 - chuni: Fix maintenance timer

Compare with previous version

In GitLab by @Felix on Mar 23, 2020, 24:16 added 6 commits <ul><li>6947912d - 1 commit from branch <code>djhackers:master</code></li><li>3b7f3ce8 - chuni: Prevent recursive item calls if user has more than 600 items</li><li>649dbe8e - chuni: Enable all events</li><li>a1cf5f60 - chuni: Put event IDs in separate static file</li><li>e53edc29 - chuni: Add remaining Chunithm Amazon event IDs</li><li>74997786 - chuni: Fix maintenance timer</li></ul> [Compare with previous version](/djhackers/minime/-/merge_requests/8/diffs?diff_id=1172&start_sha=42b71cf8d4c4c6cf818564a85f607cb473c6cd0c)
icex2 commented 2020-03-23 03:18:17 +03:00 (Migrated from github.com)

In GitLab by @tau on Mar 23, 2020, 01:18

merged

In GitLab by @tau on Mar 23, 2020, 01:18 merged
Sign in to join this conversation.