Add argument to override Services URL #63

Closed
opened 2020-10-07 08:19:24 +03:00 by icex2 · 6 comments
icex2 commented 2020-10-07 08:19:24 +03:00 (Migrated from github.com)

In GitLab by @cam_prevail on Oct 7, 2020, 07:19

A PCBID arg already exists, but it's not really useful without a services url arg. Having this would also mean you likely won't have to have multiple ea3-config files.

In GitLab by @cam_prevail on Oct 7, 2020, 07:19 A PCBID arg already exists, but it's not really useful without a services url arg. Having this would also mean you likely won't have to have multiple ea3-config files.
icex2 commented 2020-10-07 20:01:54 +03:00 (Migrated from github.com)

Sorry, but I don't really understand the use-case there. Could you elaborate by provoding an example/use-case? Which games are affected by this? Why is the PCBID arg overriding not useful without having a service url arg?

Sorry, but I don't really understand the use-case there. Could you elaborate by provoding an example/use-case? Which games are affected by this? Why is the PCBID arg overriding not useful without having a service url arg?
icex2 commented 2020-10-07 21:01:17 +03:00 (Migrated from github.com)

In GitLab by @cam_prevail on Oct 7, 2020, 20:01

Because the average player will likely never need to use a different pcbid for the same game on the same network. If they want to have a different batch file to configure for play on a different network however (or localhost/offline), they would need to switch their pcbid AND services url.
The average user also only ever needs to edit those two fields in ea3-config.xml.
I wasn't going to compare it to spicetools, but yes, I find it to be an extremely useful arg in spice, as well as their -urlslash arg.

In GitLab by @cam_prevail on Oct 7, 2020, 20:01 Because the average player will likely never need to use a different pcbid for the same game on the same network. If they want to have a different batch file to configure for play on a different network however (or localhost/offline), they would need to switch their pcbid AND services url. The average user also only ever needs to edit those two fields in ea3-config.xml. I wasn't going to compare it to spicetools, but yes, I find it to be an extremely useful arg in spice, as well as their -urlslash arg.
icex2 commented 2020-10-08 00:33:13 +03:00 (Migrated from github.com)

In GitLab by @cam_prevail on Oct 7, 2020, 23:33

My exact use-case is a dilemma I'm having right now for writing the Museca Plus usage/documentation. I want to include a batch file with a launcher line and a spice64 line that the user can uncomment for their desired tools. To make the instructions as easy as possible, and since Museca Plus can only be run offline for the time being, I'd like to be able to write this

::launcher museca.dll -K ifs_hook.dll -url http://localhost:8080

::spice64 museca.dll -k ifs_hook.dll -url http://localhost:8080

instead of having to instruct users that they need to: copy and rename their ea3-config xml, edit the url inside it, and then explain how to add the path to ea3-config.xml argument to their batch file, if they're using launcher.

Instead of having to write all of that, I would just recommend using spicetools because it's easier, but I would like to be able to recommend bemanitools as well. I'm sure it wouldn't be too difficult to add a URL arg to btools since the PCBID arg code already exists, so I would be very grateful if you could consider my feature request.

In GitLab by @cam_prevail on Oct 7, 2020, 23:33 My exact use-case is a dilemma I'm having right now for writing the Museca Plus usage/documentation. I want to include a batch file with a `launcher` line and a `spice64` line that the user can uncomment for their desired tools. To make the instructions as easy as possible, and since Museca Plus can only be run offline for the time being, I'd like to be able to write this ``` ::launcher museca.dll -K ifs_hook.dll -url http://localhost:8080 ::spice64 museca.dll -k ifs_hook.dll -url http://localhost:8080 ``` instead of having to instruct users that they need to: copy and rename their ea3-config xml, edit the url inside it, and then explain how to add the `path to ea3-config.xml` argument to their batch file, *if* they're using launcher. Instead of having to write all of that, I would just recommend using spicetools because it's easier, but I would like to be able to recommend bemanitools as well. I'm sure it wouldn't be too difficult to add a URL arg to btools since the PCBID arg code already exists, so I would be very grateful if you could consider my feature request.
icex2 commented 2020-10-08 00:47:17 +03:00 (Migrated from github.com)

Thanks for the very elaborate comments, really appreciate the effort. Your use-case is very clear and definitely a very valuable addition to have. The required change for this is also rather straight forward to add.

I briefly checked the code and adding a -U flag that allows you to specify the URL from the command line is an option, e.g. -U http://localhost:8080.

As I am currently busy with other stuff, it might take a bit until I have some spare time to pick this up.

But, this would also be a very simple task to get involved with btools contributions. So until I can pick this up, I will definitely leave this open for anyone else to pick up.

Thanks for the very elaborate comments, really appreciate the effort. Your use-case is very clear and definitely a very valuable addition to have. The required change for this is also rather straight forward to add. I briefly checked the code and adding a `-U` flag that allows you to specify the URL from the command line is an option, e.g. `-U http://localhost:8080`. As I am currently busy with other stuff, it might take a bit until I have some spare time to pick this up. But, this would also be a very simple task to get involved with btools contributions. So until I can pick this up, I will definitely leave this open for anyone else to pick up.
icex2 commented 2020-10-08 01:23:20 +03:00 (Migrated from github.com)

In GitLab by @cam_prevail on Oct 8, 2020, 24:23

Alright, thanks!

In GitLab by @cam_prevail on Oct 8, 2020, 24:23 Alright, thanks!
icex2 commented 2021-02-07 03:20:08 +03:00 (Migrated from github.com)

In GitLab by @xyen on Feb 7, 2021, 01:20

added in !71 a month ago

In GitLab by @xyen on Feb 7, 2021, 01:20 added in !71 a month ago
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#63