Split the different card reader types properly to provide a single type of implementation for the following types (suggestion/example):
icca-slotted
icca-wavepass
iccb-jubeat (seems like this needs to be treated as a special case?)
Detailed description
See the discussion and @xyen's comments at the end of !10.
Benefits
Cleaner code which results in properly documenting the different card reader types and actual differences. Having everything in one implemention (icca slotted + wavepass) makes it difficult to document and verify which features are shared.
## Summary
<!--- Provide a general summary of your changes in the Title above -->
Split the different card reader types properly to provide a single type of implementation for the following types (suggestion/example):
- icca-slotted
- icca-wavepass
- iccb-jubeat (seems like this needs to be treated as a special case?)
## Detailed description
<!--- Describe your feature in detail -->
See the discussion and @xyen's comments at the end of !10.
## Benefits
<!--- Describe the value/benefits of the feature in detail -->
Cleaner code which results in properly documenting the different card reader types and actual differences. Having everything in one implemention (icca slotted + wavepass) makes it difficult to document and verify which features are shared.
## Drawbacks
<!--- Describe any drawbacks that might be introduced with this feature -->
Involves more code/modules with copy/paste.
## Current blockers
<!--- Describe any blockers that need to be resolved before implementing this feature -->
#40 should be done before this.
Was working on adding wavepass support to aciodrv / eamio-icca, there'll be some notes in there that'll help with this when we get around to it.
Unfortunately I don't think we can do this cleanly without completely breaking the eamio interface, I think this'll be better left to BT6 / whenever we do all our planned compat breaking (if ever).
In GitLab by @xyen on Mar 17, 2021, 24:24
Was working on adding wavepass support to aciodrv / eamio-icca, there'll be some notes in there that'll help with this when we get around to it.
Unfortunately I don't think we can do this cleanly without completely breaking the eamio interface, I think this'll be better left to BT6 / whenever we do all our planned compat breaking (if ever).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Split the different card reader types properly to provide a single type of implementation for the following types (suggestion/example):
Detailed description
See the discussion and @xyen's comments at the end of !10.
Benefits
Cleaner code which results in properly documenting the different card reader types and actual differences. Having everything in one implemention (icca slotted + wavepass) makes it difficult to document and verify which features are shared.
Drawbacks
Involves more code/modules with copy/paste.
Current blockers
#40 should be done before this.
In GitLab by @xyen on Mar 17, 2021, 24:24
Was working on adding wavepass support to aciodrv / eamio-icca, there'll be some notes in there that'll help with this when we get around to it.
Unfortunately I don't think we can do this cleanly without completely breaking the eamio interface, I think this'll be better left to BT6 / whenever we do all our planned compat breaking (if ever).