Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

Possible denial of service when config.exe is not found next to config.bat #35

New Issue
Closed
opened 2019-10-20 11:36:37 +03:00 by icex2 · 4 comments
icex2 commented 2019-10-20 11:36:37 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @lodyb on Oct 20, 2019, 10:36

Summary

When you open config.bat it looks for 'config' and if there is no config.exe found it will just open config.bat infinitely

Expected behavior

Click on config.bat, the script tries to run config.exe and gives up if it is not there

Current behavior

Click on config.bat, the script looks for 'config', and another instance of config.bat is opened

Possible solution

Specify config.exe in all config.bat files

Context (Environment)

Bemanitools version(s) affected

  • Every version

Game(s) and version(s) affected

  • Every game
In GitLab by @lodyb on Oct 20, 2019, 10:36 ## Summary When you open config.bat it looks for 'config' and if there is no config.exe found it will just open config.bat infinitely ## Expected behavior Click on config.bat, the script tries to run config.exe and gives up if it is not there ## Current behavior Click on config.bat, the script looks for 'config', and another instance of config.bat is opened ## Possible solution Specify config.exe in all config.bat files ## Context (Environment) ### Bemanitools version(s) affected * Every version ### Game(s) and version(s) affected * Every game
icex2 commented 2019-10-21 00:15:54 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Oct 20, 2019, 23:15

Oh yeah, this happens.

Will fix.

In GitLab by @xyen on Oct 20, 2019, 23:15 Oh yeah, this happens. Will fix.
icex2 commented 2019-10-25 03:33:27 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Oct 25, 2019, 02:33

mentioned in commit 69ee95c79a

In GitLab by @xyen on Oct 25, 2019, 02:33 mentioned in commit 69ee95c79af31d054309de5a9b8c7c87b4f3ee7e
icex2 commented 2019-10-25 03:35:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Oct 25, 2019, 02:35

closed

In GitLab by @xyen on Oct 25, 2019, 02:35 closed
icex2 commented 2019-10-25 03:35:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Oct 25, 2019, 02:35

Fixed.

In GitLab by @xyen on Oct 25, 2019, 02:35 Fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#35