I guess that works, but compared to the other ways it detects different devices, it feels a bit off.
Do we ever have multiple acio devices on the same bus with any BI2A device? To my knowledge, the BI2A device is always on its own bus exclusively (please correct me here if I am wrong).
Assuming that's the case, I suggest to extend the tool rather to allow selecting different "kinds" of devices.
Examples how to call aciotest:
aciotest.exe COM1 57600 for a "generic" acio device that does the entire "go by product code" thing
aciotest.exe COM1 57600 bi2a-iidx for the iidx BI2A mode
aciotest.exe COM1 57600 bi2a-sdvx for the sdvx BI2A mode
Mind tweaking the tool a little to have it work like that?
The actual extension of the tool already looks good to me.
I guess that works, but compared to the other ways it detects different devices, it feels a bit off.
Do we ever have multiple acio devices on the same bus with any BI2A device? To my knowledge, the BI2A device is always on its own bus exclusively (please correct me here if I am wrong).
Assuming that's the case, I suggest to extend the tool rather to allow selecting different "kinds" of devices.
Examples how to call `aciotest`:
* `aciotest.exe COM1 57600` for a "generic" acio device that does the entire "go by product code" thing
* `aciotest.exe COM1 57600 bi2a-iidx` for the iidx BI2A mode
* `aciotest.exe COM1 57600 bi2a-sdvx` for the sdvx BI2A mode
Mind tweaking the tool a little to have it work like that?
The actual extension of the tool already looks good to me.
If you want, you can follow up with another small refactoring PR to improve this. The current solution is fine though considering it's just two modes now and scoped to a single file.
Non-blocking remark to take away as a learning: An enum would improve readability here, e.g.
```
enum BI2A_MODE {
BI2A_MODE_INVALID = 0,
BI2A_MODE_SDVX = 1,
BI2A_MODE_IIDX = 2,
};
```
If you want, you can follow up with another small refactoring PR to improve this. The current solution is fine though considering it's just two modes now and scoped to a single file.
Not sure where the conflicts are. It doesn't mention any specific files. Can you check on your end if you are up to date with djhackersdev:master and fix that if needed?
Otherwise, I can't merge it.
"This branch cannot be rebased due to conflicts"
Not sure where the conflicts are. It doesn't mention any specific files. Can you check on your end if you are up to date with [djhackersdev:master](https://github.com/djhackersdev/bemanitools/tree/master) and fix that if needed?
Otherwise, I can't merge it.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
I guess that works, but compared to the other ways it detects different devices, it feels a bit off.
Do we ever have multiple acio devices on the same bus with any BI2A device? To my knowledge, the BI2A device is always on its own bus exclusively (please correct me here if I am wrong).
Assuming that's the case, I suggest to extend the tool rather to allow selecting different "kinds" of devices.
Examples how to call
aciotest:aciotest.exe COM1 57600for a "generic" acio device that does the entire "go by product code" thingaciotest.exe COM1 57600 bi2a-iidxfor the iidx BI2A modeaciotest.exe COM1 57600 bi2a-sdvxfor the sdvx BI2A modeMind tweaking the tool a little to have it work like that?
The actual extension of the tool already looks good to me.
Sorted!
Non-blocking remark to take away as a learning: An enum would improve readability here, e.g.
If you want, you can follow up with another small refactoring PR to improve this. The current solution is fine though considering it's just two modes now and scoped to a single file.
Looking good, thanks for following up on the suggestion.
"This branch cannot be rebased due to conflicts"
Not sure where the conflicts are. It doesn't mention any specific files. Can you check on your end if you are up to date with djhackersdev:master and fix that if needed?
Otherwise, I can't merge it.
Sure, I'll do it later
Thanks for following up. Merged.