Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

Feature: vigem driver for ddrio #247

Merged
dinsfire64 merged 3 commits from ddrio-vigem into master 2023-04-11 19:04:36 +03:00
Conversation 8 Commits 3 Files Changed 5
+356
dinsfire64 commented 2023-04-11 00:43:04 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Reads state of ddrio and updates vigem pads. Similar in vein to viggem-sdvxio and vigem-iidxio

Useful for playing xinput related games with official hardware.

Reads state of ddrio and updates vigem pads. Similar in vein to viggem-sdvxio and vigem-iidxio Useful for playing xinput related games with official hardware.
icex2 (Migrated from github.com) reviewed 2023-04-11 00:43:04 +03:00
icex2 commented 2023-04-11 01:22:11 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Really nice one, looking forward to giving this a try on my own cabinet.

I noticed we have some brief docs for the iidxio and sdvxio vigem clients. It would be cool to have something similar to these for the ddrio one as well and link it from the doc/vigem/README.md.

Really nice one, looking forward to giving this a try on my own cabinet. I noticed we have some brief docs for the iidxio and sdvxio vigem clients. It would be cool to have something similar to these for the ddrio one as well and link it from the doc/vigem/README.md.
icex2 (Migrated from github.com) reviewed 2023-04-11 01:24:15 +03:00
src/main/vigem-ddrio/config-vigem-ddrio.c
icex2 (Migrated from github.com) commented 2023-04-11 01:24:15 +03:00
Copy Link
Copy Source

What config inputs?

What config inputs?
icex2 (Migrated from github.com) reviewed 2023-04-11 01:25:58 +03:00
src/main/vigem-ddrio/main.c
icex2 (Migrated from github.com) commented 2023-04-11 01:25:57 +03:00
Copy Link
Copy Source
        // avoid CPU banging

:P

```suggestion // avoid CPU banging ``` :P
icex2 commented 2023-04-11 01:27:11 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Code's looking good. Give me a ping using the "re-request review" feature and I will have a another peek and merge this asap.

Code's looking good. Give me a ping using the "re-request review" feature and I will have a another peek and merge this asap.
dinsfire64 (Migrated from github.com) reviewed 2023-04-11 16:33:49 +03:00
src/main/vigem-ddrio/config-vigem-ddrio.c
dinsfire64 (Migrated from github.com) commented 2023-04-11 16:33:48 +03:00
Copy Link
Copy Source

Typo from using vigem-sdvxio as template. Fixed.

Typo from using vigem-sdvxio as template. Fixed.
dinsfire64 (Migrated from github.com) reviewed 2023-04-11 16:33:58 +03:00
src/main/vigem-ddrio/main.c
dinsfire64 (Migrated from github.com) commented 2023-04-11 16:33:57 +03:00
Copy Link
Copy Source

fixed in new comit.

fixed in new comit.
icex2 commented 2023-04-11 19:04:52 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Great work, thanks. Merged.

Great work, thanks. Merged.
Sign in to join this conversation.
Reviewers
No Reviewers
icex2
dinsfire64
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#247