Fixed gamestart.bat files for Chinese IIDX styles to prevent the games from hanging
Description
Chinese IIDX styles will hang if bemanitools can't mount the dev\nvram and dev\raw folders. This simply adds commands to their gamestart.bat files to create those directories if they don't exist, preventing the game from hanging.
(I hope I did this all correctly, I really didn't feel like taking a deep dive into Git to add two lines to two batch files >_>)
Deleted the dev folder I created, ensured the game hangs with the old gamestart.bat files, and then ensured it runs with the new gamestart.bat files
Checklist
Implemented (unit) test(s) which prove that the introduced changes are working as expected.
Tested with the following games:
Chinese IIDX Resort Anthem
Chinese IIDX tricoro
Followed the developer (style) guidelines.
Updated existing doc of or add new doc to README file(s).
Updated development documentation.
In GitLab by @JeffPaine on Dec 18, 2022, 12:43
_Merges master -> master_
## Summary
Fixed gamestart.bat files for Chinese IIDX styles to prevent the games from hanging
## Description
Chinese IIDX styles will hang if bemanitools can't mount the dev\nvram and dev\raw folders. This simply adds commands to their gamestart.bat files to create those directories if they don't exist, preventing the game from hanging.
(I hope I did this all correctly, I really didn't feel like taking a deep dive into Git to add two lines to two batch files >_>)
## Related Issue
https://dev.s-ul.net/djhackers/bemanitools/-/issues/101
## How Has This Been Tested?
Deleted the dev folder I created, ensured the game hangs with the old gamestart.bat files, and then ensured it runs with the new gamestart.bat files
## Checklist
* [X] Implemented (unit) test(s) which prove that the introduced changes are working as expected.
* Tested with the following games:
* [X] Chinese IIDX Resort Anthem
* [X] Chinese IIDX tricoro
* [ ] ~~Followed the developer (style) guidelines.~~
* [ ] ~~Updated existing doc of or add new doc to README file(s).~~
* [ ] ~~Updated development documentation.~~
lgtm, good job and thanks for taking the time debugging this and opening the MR. Looks identical to what other IIDX versions also need/have in their respective gamestart.bat files.
lgtm, good job and thanks for taking the time debugging this and opening the MR. Looks identical to what other IIDX versions also need/have in their respective gamestart.bat files.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @JeffPaine on Dec 18, 2022, 12:43
Merges master -> master
Summary
Fixed gamestart.bat files for Chinese IIDX styles to prevent the games from hanging
Description
Chinese IIDX styles will hang if bemanitools can't mount the dev\nvram and dev\raw folders. This simply adds commands to their gamestart.bat files to create those directories if they don't exist, preventing the game from hanging.
(I hope I did this all correctly, I really didn't feel like taking a deep dive into Git to add two lines to two batch files >_>)
Related Issue
https://dev.s-ul.net/djhackers/bemanitools/-/issues/101
How Has This Been Tested?
Deleted the dev folder I created, ensured the game hangs with the old gamestart.bat files, and then ensured it runs with the new gamestart.bat files
Checklist
Followed the developer (style) guidelines.Updated existing doc of or add new doc to README file(s).Updated development documentation.lgtm, good job and thanks for taking the time debugging this and opening the MR. Looks identical to what other IIDX versions also need/have in their respective gamestart.bat files.
approved this merge request