A dumb little change, it just adds a menu to the .bat files to select the beat phase from instead of specifying it as a parameter, as well as check to make sure it was actually successful.
In GitLab by @PolarManne on Sep 9, 2022, 20:37
_Merges master -> master_
A dumb little change, it just adds a menu to the .bat files to select the beat phase from instead of specifying it as a parameter, as well as check to make sure it was actually successful.
Sorry for the late reply, life is keeping me busy.
I like the idea with the menu but in the current state, it removes the ability to run it without the menu, e.g. to use it in other scripts. Can you add this back? One option would be to check the first argument in the beginning of the script and if it is set, skip the menu and run the patch. If not provided, show the menu and proceed after user input.
Sorry for the late reply, life is keeping me busy.
I like the idea with the menu but in the current state, it removes the ability to run it without the menu, e.g. to use it in other scripts. Can you add this back? One option would be to check the first argument in the beginning of the script and if it is set, skip the menu and run the patch. If not provided, show the menu and proceed after user input.
In GitLab by @PolarManne on Oct 1, 2022, 18:32
added 1 commit
<ul><li>7af5ffe8 - Allow passing arguments and terminal close fix</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/130/diffs?diff_id=2719&start_sha=35c76d388ee70dded594634505aad285f8a28049)
Added the ability to do that. It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1.
Sorry it took so long to get back, been sick off my ass as of late.
In GitLab by @PolarManne on Oct 1, 2022, 18:34
Added the ability to do that. It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1.
Sorry it took so long to get back, been sick off my ass as of late.
Thanks for following up and putting effort into polishing this, appreciated.
It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1.
I think that's fine and actually makes more sense from a user's perspective. No objections.
Sorry it took so long to get back, been sick off my ass as of late.
No worries, hope you are better now.
> Added the ability to do that.
Thanks for following up and putting effort into polishing this, appreciated.
> It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1.
I think that's fine and actually makes more sense from a user's perspective. No objections.
> Sorry it took so long to get back, been sick off my ass as of late.
No worries, hope you are better now.
Sorry for getting back so late about this. I just noticed this one still being open which is odd because I approved it already 2 months ago. No idea why I have not merged this, yet.
Trying to do that now, gitlab just shows me a "Something went wrong. Please try again." error message. It seems like the source branch PolarManne/bemanitools:master does not exist anymore or cannot be accessed (permission issue).
If you still want this merged, can you check what might be wrong with your source branch?
@PolarManne
Sorry for getting back so late about this. I just noticed this one still being open which is odd because I approved it already 2 months ago. No idea why I have not merged this, yet.
Trying to do that now, gitlab just shows me a "Something went wrong. Please try again." error message. It seems like the source branch `PolarManne/bemanitools:master` does not exist anymore or cannot be accessed (permission issue).
If you still want this merged, can you check what might be wrong with your source branch?
@PolarManne
It was set to private so probably a permissions issue. I've switched my repo to public so try it again.
In GitLab by @PolarManne on Dec 20, 2022, 18:11
It was set to private so probably a permissions issue. I've switched my repo to public so try it again.
GitLab is being dumb and doesn't allow me to merge this MR anymore. Apparently, it still fights some 404 issues that should not be the case anymore.
I opened a new MR, https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/130, with the changes and appointed you as the author. Merging the other MR and closing this one to conclude this.
Thanks again and sorry for the mess.
GitLab is being dumb and doesn't allow me to merge this MR anymore. Apparently, it still fights some 404 issues that should not be the case anymore.
I opened a new MR, https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/130, with the changes and appointed you as the author. Merging the other MR and closing this one to conclude this.
Thanks again and sorry for the mess.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @PolarManne on Sep 9, 2022, 20:37
Merges master -> master
A dumb little change, it just adds a menu to the .bat files to select the beat phase from instead of specifying it as a parameter, as well as check to make sure it was actually successful.
Sorry for the late reply, life is keeping me busy.
I like the idea with the menu but in the current state, it removes the ability to run it without the menu, e.g. to use it in other scripts. Can you add this back? One option would be to check the first argument in the beginning of the script and if it is set, skip the menu and run the patch. If not provided, show the menu and proceed after user input.
In GitLab by @PolarManne on Oct 1, 2022, 18:32
added 1 commit
Compare with previous version
In GitLab by @PolarManne on Oct 1, 2022, 18:34
Added the ability to do that. It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1.
Sorry it took so long to get back, been sick off my ass as of late.
Thanks for following up and putting effort into polishing this, appreciated.
I think that's fine and actually makes more sense from a user's perspective. No objections.
No worries, hope you are better now.
resolved all threads
approved this merge request
Sorry for getting back so late about this. I just noticed this one still being open which is odd because I approved it already 2 months ago. No idea why I have not merged this, yet.
Trying to do that now, gitlab just shows me a "Something went wrong. Please try again." error message. It seems like the source branch
PolarManne/bemanitools:masterdoes not exist anymore or cannot be accessed (permission issue).If you still want this merged, can you check what might be wrong with your source branch?
@PolarManne
In GitLab by @PolarManne on Dec 20, 2022, 18:11
It was set to private so probably a permissions issue. I've switched my repo to public so try it again.
GitLab is being dumb and doesn't allow me to merge this MR anymore. Apparently, it still fights some 404 issues that should not be the case anymore.
I opened a new MR, https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/130, with the changes and appointed you as the author. Merging the other MR and closing this one to conclude this.
Thanks again and sorry for the mess.